search

ColinLefter / Accord

A real-time privacy-first social media platform leveraging feature-rich direct messaging text channels. Built as part of the course project for COSC 310 at UBC.
5 stars 1 forks source link

Group chat added to user #167

Closed ThunderIW closed 3 months ago

ColinLefter commented 3 months ago

Was previously closed due to the fact that this pull request includes a poorly-constructed API endpoint (GroupChatUser) that not only uses a collection that has absolutely no data in it (you mention id but that collection does not even have an id property?), but that collection in itself is an attempt at duplicating the Chats collection. Please revise your code to work with the Chats collection. The first API endpoint is ok since we do need to get a group chat by channel ID.

ColinLefter commented 3 months ago

I would also like to see stricter reviews as such a pull request would have been auto-declined in less than 5 seconds had I reviewed it.