search

ColinPitrat / kalenji-gps-watch-reader

A tool to import data from some Kalenji running watches
GNU General Public License v3.0
30 stars 11 forks source link

Low test coverage on some features #46

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Providing test coverage shows that some features are not tested at all, or 
nearly not tested. Files with less than 50% of coverage are:

File 'src/device/Keymaze.cc' - Lignes exécutées: 0.75% de 268
File 'src/source/Logger.h' - Lignes exécutées: 0.00% de 3
File 'src/Utils.h' - Lignes exécutées: 0.00% de 8
File 'src/source/Logger.cc' - Lignes exécutées: 3.70% de 27
File 'src/output/Fitlog.cc' - Lignes exécutées: 4.35% de 46
File 'src/filter/UnreliablePoints.cc' - Lignes exécutées: 9.09% de 22
File 'src/output/GoogleStaticMap.cc' - Lignes exécutées: 11.11% de 18
File 'src/source/USB.cc' - Lignes exécutées: 18.48% de 92
File 'src/filter/NullHeartrate.cc' - Lignes exécutées: 20.00% de 10
File 'src/filter/EmptyLaps.cc' - Lignes exécutées: 22.22% de 9
File 'src/device/Keymaze.h' - Lignes exécutées: 28.57% de 7

It appears that there is no test for:
 - Keymaze device
 - Logger source
 - Fitlog and GoogleStaticMap output
 - UnreliablePoints, NullHeartrate and EmptyLaps filters

The absence of testing of USB is expected but it would still be interesting to 
check if something can/should be done about it.

Original issue reported on code.google.com by colin.pi...@gmail.com on 23 Dec 2014 at 8:56

GoogleCodeExporter commented 9 years ago

Original comment by colin.pi...@gmail.com on 23 Dec 2014 at 8:57

GoogleCodeExporter commented 9 years ago 
Added unit tests for:
File 'src/filter/UnreliablePoints.cc' - Lignes exécutées: 9.09% de 22
File 'src/filter/NullHeartrate.cc' - Lignes exécutées: 20.00% de 10

Added integrated tests for:
File 'src/output/Fitlog.cc' - Lignes exécutées: 4.35% de 46
File 'src/output/GoogleStaticMap.cc' - Lignes exécutées: 11.11% de 18

Remains:
File 'src/device/Keymaze.h/cc'
File 'src/source/Logger.h/cc'
File 'src/Utils.h/cc'
File 'src/source/USB.h/cc'
File 'src/filter/EmptyLaps.h/cc'

Original comment by colin.pi...@gmail.com on 27 Dec 2014 at 10:22

ColinPitrat commented 9 years ago

Improved coverage of: File 'src/filter/EmptyLaps.h/cc'

Remains: File 'src/device/Keymaze.h/cc' File 'src/source/Logger.h/cc' File 'src/Utils.h/cc' File 'src/source/USB.h/cc'

ColinPitrat commented 9 years ago

Files that are worth having a look to:

File 'src/main.cc' - Lines executed:56.85% of 241 File 'src/device/Kalenji.cc' - Lines executed:54.72% of 318 File 'src/source/USB.cc' - Lines executed:10.99% of 91 File 'src/filter/UnreliablePoints.cc' - Lines executed:9.09% of 22 File 'src/source/Logger.cc' - Lines executed:3.70% of 27 File 'src/device/Keymaze.cc' - Lines executed:0.77% of 259