search

ColinPitrat / kalenji-gps-watch-reader

A tool to import data from some Kalenji running watches
GNU General Public License v3.0
30 stars 11 forks source link

Added fix for wrong start of session with OnMove200 device #75

Open fpb opened 5 years ago

fpb commented 5 years ago

Just a simple fix for wrong start of session on OnMove200. I used the duration and subtracted it from the session start time.

ColinPitrat commented 5 years ago

This is breaking the integration tests (expected, it's probably just the timing change).

You can run the tests with make test. After verifying that the change is really the one expected, typically with: diff test/integrated/case12/results/20160903_220600.gpx /tmp/case12/20160903_220600.gpx

you can just copy the generated one over the expected and add it to the PR: cp /tmp/case12/20160903_220600.gpx test/integrated/case12/results/20160903_220600.gpx

Tell me if you meet any issue. Thanks !

ColinPitrat commented 3 years ago

@fpb do you plan to fix this PR?