CollActionteam / collaction_app

CollAction cross-platform mobile application for iOS and Android
https://collaction.org
GNU General Public License v3.0
33 stars 12 forks source link

[UnitTest]: Implement testing on all DTOs #224

Closed Xazin closed 1 year ago

Xazin commented 2 years ago

As part of the effort of implementing high coverage in our application, we will need to implement tests for all of our data transfer objects known as DTOs.

For each DTO, we will need:

The DTOs we need to implement tests for are:

Note: Find a good way to separate the fixture from the test itself (eg. /tests/dto/crowdaction/fixtures.dart and /tests/dto/crowdaction/tests.dart), to keep the test file as clean as possible. Remember to use readable names for the variables, and try to explain the tests best as possible, to let others more easily understand the tests.

saksham-gt commented 2 years ago

233 : added tests for Profile DTOs.

yasht01 commented 2 years ago

@Xazin tests for .fromJson() method for ContactFormDTO have already been implemented. Is there anything more to be implemented for the ContactFormDTO? (There is no toDomain() method here). I'll work on CrowdactionDTO in the meantime

DerrickWilliamson commented 2 years ago

Apologies for marking the entire issue closed. Only meant to mark the Images DTO task as complete. Have reopened.

Xazin commented 2 years ago

Updated with some new DTOs on the list

DerrickWilliamson commented 2 years ago

All DTO unit tests have been completed and pushed to development.