CollActionteam / collaction_app

CollAction cross-platform mobile application for iOS and Android
https://collaction.org
GNU General Public License v3.0
33 stars 12 forks source link

ft: Enable deep-links #343

Open wizlif opened 1 year ago

wizlif commented 1 year ago

Enables ability to use deep-links to traverse the app routes.

Android

iOs

Issue: iOs launches safari with link for https schemes

Android Preview

https://user-images.githubusercontent.com/15793624/212828992-9bf0bde6-cbf0-4baf-ad5c-ce1e24a3f7ec.mov

iOs Preview

https://user-images.githubusercontent.com/15793624/212829554-80bbbfaa-907b-43d2-b219-4f81d89a1575.mov

https://user-images.githubusercontent.com/15793624/212829419-f802ac13-a039-4eee-bb99-a171e6a5cd3b.mov

Closes #287

Xazin commented 1 year ago

Don't we also need to set this up on our domains: https://developer.apple.com/documentation/xcode/supporting-associated-domains

codecov[bot] commented 1 year ago

Codecov Report

Merging #343 (25f89ae) into development (023d67e) will increase coverage by 2.22%. The diff coverage is 60.00%.

@@               Coverage Diff               @@
##           development     #343      +/-   ##
===============================================
+ Coverage        66.55%   68.78%   +2.22%     
===============================================
  Files              157      157              
  Lines             4010     4017       +7     
===============================================
+ Hits              2669     2763      +94     
+ Misses            1341     1254      -87     
Impacted Files Coverage Δ
...rowdaction_details/crowdaction_details_screen.dart 58.86% <50.00%> (+58.86%) :arrow_up:
lib/presentation/home/widgets/password_modal.dart 92.85% <66.66%> (-2.67%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

wizlif commented 1 year ago

https://developer.apple.com/documentation/xcode/supporting-associated-domains

Yes we do, we could pass it via CI

wizlif commented 1 year ago

https://user-images.githubusercontent.com/15793624/213756508-68fb9f30-7b7f-42c1-a218-e6ce507bd98e.mov

wizlif commented 1 year ago

https://user-images.githubusercontent.com/15793624/215290642-99d53af2-2537-41be-b9a4-0601b9b3c7d7.mp4

Xazin commented 1 year ago

We need to rebase this, and then we should be able to merge.

wizlif commented 1 year ago

Let me cherry pick the major changes

wizlif commented 1 year ago

@Xazin Let’s first merge https://github.com/CollActionteam/collaction_app/pull/343 before i rebase. Some minor conflicts between the two.