CollActionteam / collaction_app

CollAction cross-platform mobile application for iOS and Android
https://collaction.org
GNU General Public License v3.0
33 stars 12 forks source link

added country flags #354

Closed eStarKee06 closed 1 year ago

eStarKee06 commented 1 year ago

https://github.com/CollActionteam/collaction_app/issues/350

codecov[bot] commented 1 year ago

Codecov Report

Merging #354 (8e6641a) into development (3519ad0) will increase coverage by 0.23%. The diff coverage is 96.87%.

@@               Coverage Diff               @@
##           development     #354      +/-   ##
===============================================
+ Coverage        59.87%   60.11%   +0.23%     
===============================================
  Files              156      157       +1     
  Lines             4000     4024      +24     
===============================================
+ Hits              2395     2419      +24     
  Misses            1605     1605              
Impacted Files Coverage Δ
.../presentation/shared_widgets/crowdaction_card.dart 96.72% <92.85%> (+0.42%) :arrow_up:
...on_details/widgets/crowdaction_details_banner.dart 84.37% <100.00%> (+5.20%) :arrow_up:
lib/presentation/shared_widgets/country_icon.dart 100.00% <100.00%> (ø)
...ntation/shared_widgets/micro_crowdaction_card.dart 95.45% <100.00%> (+0.33%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Xazin commented 1 year ago

The alignment of the flag vs. the lock icon is correct, it's because of it being RTL on the CrowdAction Card and Banner, whereas on the Micro Card it's LTR.

Xazin commented 1 year ago

@eStarKee06 Can you resolve the analyzer error so we can merge? :+1:

Xazin commented 1 year ago

350

  • the only one I haven't tested is the details banner with a lock; I realized I don't actually know what the password is to the test data lol

There are crowdactions without a password, and the password is most likely veganuary-2022