Closed wizlif closed 1 year ago
Merging #391 (77f787d) into development (db8283d) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## development #391 +/- ##
===============================================
+ Coverage 65.65% 65.69% +0.04%
===============================================
Files 161 161
Lines 4067 4066 -1
===============================================
+ Hits 2670 2671 +1
+ Misses 1397 1395 -2
Impacted Files | Coverage Δ | |
---|---|---|
lib/core/config/network_config.dart | 66.66% <100.00%> (+16.66%) |
:arrow_up: |
lib/domain/crowdaction/crowdaction.dart | 94.73% <100.00%> (ø) |
|
lib/domain/participation/participation.dart | 100.00% <100.00%> (ø) |
|
lib/presentation/profile/profile_screen.dart | 41.60% <100.00%> (+0.65%) |
:arrow_up: |
.../presentation/shared_widgets/crowdaction_card.dart | 96.77% <100.00%> (ø) |
|
...esentation/shared_widgets/participant_avatars.dart | 90.47% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
We could alternatively remove widgetbook and move it to the collaction_ui repository, and then all widgets in collaction_ui/packages/...
need to be inside widgetbook. (Dependency by path inside Widgetbook package).
What do you think?
That would be the best option, but will take some time as we shift slowly.
We could alternatively remove widgetbook and move it to the collaction_ui repository, and then all widgets in
collaction_ui/packages/...
need to be inside widgetbook. (Dependency by path inside Widgetbook package).What do you think?
Related: https://github.com/CollActionteam/collaction_ui/issues/4
We could alternatively remove widgetbook and move it to the collaction_ui repository, and then all widgets in
collaction_ui/packages/...
need to be inside widgetbook. (Dependency by path inside Widgetbook package). What do you think?Related: CollActionteam/collaction_ui#4
Awesome, let me try to migrate atleast one or two widgets then we can sample.
We can skip widget_book generation when running tests since the Widget Book files are already generated and cached in the analyze step of CI.