CollActionteam / collaction_app

CollAction cross-platform mobile application for iOS and Android
https://collaction.org
GNU General Public License v3.0
34 stars 12 forks source link

Feat/gh399/update appicons #404

Closed sarahaudina closed 1 year ago

sarahaudina commented 1 year ago

close #399

codecov[bot] commented 1 year ago

Codecov Report

Merging #404 (8b5a695) into development (b65fbbf) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #404   +/-   ##
============================================
  Coverage        66.34%   66.34%           
============================================
  Files              157      157           
  Lines             4077     4077           
============================================
  Hits              2705     2705           
  Misses            1372     1372           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

wizlif commented 1 year ago

Thanks for the update, seems you didn’t use https://pub.dev/packages/flutter_launcher_icons . You can simply update the assets/images/icons/app_icon.png to the new icon then run flutter pub run flutter_launcher_icons to generate all icons.

sarahaudina commented 1 year ago

Oh right, thanks for mentioning it @wizlif . I will update to use the lib today.

sarahaudina commented 1 year ago

I had to change remove_alpha_ios to false, so the icon's corner not black colored on ios. Let me know if this will be a problem @wizlif . Thanks.

wizlif commented 1 year ago

Btw @sarahaudina , just another thought popped. Can't we fill the curving transparent side and use the original configuration. Coz I'm sure on android the border radius on the icon is defined by the system e.g by a theme. [Not sure about iOs].

What do you think ??