search

CollActionteam / collaction_backend

Backend code for CollAction
6 stars 4 forks source link

Badges #99

Open rubenhorn opened 2 years ago

rubenhorn commented 2 years ago

⚠ Blocked by #111

rubenhorn commented 2 years ago

@Xazin Do we want users to claim badges (👎 interaction required from every user) or admins to issue them to all participants through the CMS (👎 minimal admin effort, 👎 CMS needs extra UI, BUT 👍 would allow simple manual awarding to users e.g. "most active community member" / "early birds" without the need for additional logic)? The latter would also require changes to #93.

Alternatively we could schedule a CRON job to automatically award badges at the end of a crowdaction.

rubenhorn commented 2 years ago

Branch already started. Please continue on #100. ⚠ Make sure to merge development first to update the branch!

Xazin commented 2 years ago

@Xazin Do we want users to claim badges (👎 interaction required from every user) or admins to issue them to all participants through the CMS (👎 minimal admin effort, 👎 CMS needs extra UI, BUT 👍 would allow simple manual awarding to users e.g. "most active community member" / "early birds" without the need for additional logic)? The latter would also require changes to #93.

Alternatively we could schedule a CRON job to automatically award badges at the end of a crowdaction.

Badges should be "automatically assigned" to users. We should have a Cron job as you mentioned, and the badges that are awarded and their requirements should be inside the CrowdAction (?) most likely.

Alternatively, we can add a CMS endpoint, to award badges (mvp) as you mentioned as a first-version.

rubenhorn commented 2 years ago

I guess it also depends on what we want to award. (Can this be determined based on the participation? 👉 CRON, do we want award individual/off-platform achievements? 👉 CMS)

Xazin commented 2 years ago

I guess it also depends on what we want to award. (Can this be determined based on the participation? 👉 CRON, do we want award individual/off-platform achievements? 👉 CMS)

This is a good point, let's discuss this today with the others.

rubenhorn commented 2 years ago

CRON job will be implemented as part of #120

edreinoso commented 2 years ago

I believe that even before awarding badges to the users, we should implement the logic for the pointing system that is specified in this documentation.

https://collaction.atlassian.net/wiki/spaces/DOC/pages/2537226279/CollAction+app+features

rubenhorn commented 2 years ago

I believe that even before awarding badges to the users, we should implement the logic for the pointing system that is specified in this documentation.

https://collaction.atlassian.net/wiki/spaces/DOC/pages/2537226279/CollAction+app+features

This system is not going to be used in the first iteration, since we will not have sufficient time to test and balance it.
Instead, points are awarded per commitment of a user. This is sufficient for the initial crowdactions.

edreinoso commented 2 years ago

I am a bit confused about the issue numbering here. So we have this ticket that is #99. We also have another one #100 and yet another one #120. So should I continue in the branch that was created for ticket #100?

Regardless the ticket numbering, I believe that most of the work for this badge logic is going to be done in the lambda that will be triggered once the crowdaction ends. I believe this is the ticket #120. This is because the badge would only be awarded at the moment when the crowdaction is over.

rubenhorn commented 2 years ago

Sorry, I don't always create the issues in chronological order and the creation of PRs also interferes with this, so the numbers can be a bit arbitrary.

Sorry for the confusion.
As I previously said, I am trying to split up tasks into smaller pieces that can be worked on over a shorter period.

edreinoso commented 2 years ago

No need to apologise man. I believe you're doing a great job managing this. It just takes a bit communication, which is completely fine for me. I will continue with this work today and tomorrow