CollActionteam / collaction_cms

This is the UI interface for the CMS API
6 stars 3 forks source link

Support for user profile. #15

Open dromerolovo opened 1 year ago

dromerolovo commented 1 year ago
andre-tm-hui commented 1 year ago

Regarding #56, I'm noticing the user profiles on Firebase don't necessarily have a name set for them. Do we want to display the email instead? Or should we add editing of user profiles in the future?

dromerolovo commented 1 year ago

What if we parse the username of the email. E.g diego@collaction.org. So the "name" would be diego. And we format the name with titleCase ?

andre-tm-hui commented 1 year ago

We can do that for the time being. Correct me if I'm wrong @Xazin, but the goal is to pull user profiles from the API, and get names from there, which likely means we'll need a ProfileRepository to manage that. Moreover, extra checks will be needed to ensure only users with existing profiles can be invited as moderators?

Xazin commented 1 year ago

We can do that for the time being. Correct me if I'm wrong @Xazin, but the goal is to pull user profiles from the API, and get names from there, which likely means we'll need a ProfileRepository to manage that. Moreover, extra checks will be needed to ensure only users with existing profiles can be invited as moderators?

  1. A profile is something generic, it consists only of information about a user.

  2. Any user, even if they do not exist already, can be invited. (We can setup some "link to CollAction user")

  3. We need a way to Manage Users, I believe this might have been part of the original intent of this issue. That should be a separate issue.

  4. We can alter the flow, such that new moderators can enter first and last name, and choose or upload an avatar.

andre-tm-hui commented 1 year ago

To clarify, when a user joins/creates a profile in the app, is a Firebase user created for them automatically? Or are they completely separate?

Xazin commented 1 year ago

To clarify, when a user joins/creates a profile in the app, is a Firebase user created for them automatically? Or are they completely separate?

They are completely decoupled.

The firebase user comes first, how would a user have a profile without being able to sign in.

API documentation for endpoints https://devapi.collaction.org/