CollActionteam / collaction_cms

This is the UI interface for the CMS API
6 stars 3 forks source link

refactor: clean project #53

Closed Xazin closed 1 year ago

Xazin commented 1 year ago

A lot of cleaning

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit c24640b):

https://collaction-development--pr53-refactor-spring-clea-rlcgg50d.web.app

(expires Sat, 25 Mar 2023 23:46:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2cf09e8dbf51d2eab3fc6679b673d248bc8047bb

Xazin commented 1 year ago

Other reason why running this branch is throwing an error is because there are some plugins that need an AndroidManifest file that's why when I run this project locally, I get the following error:

`This app is using a deprecated version of the Android embedding.

To avoid unexpected runtime failures, or future build failures, try to migrate this app to the V2 embedding. Take a look at the docs for migrating an app: https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects

The plugin firebase_auth requires your app to be migrated to the Android embedding v2. Follow the steps on the migration doc above and re-run this command.`

Could be fixed by running flutter create -a kotlin .

That does not make sense, project does not run on android.

dromerolovo commented 1 year ago

Just for the record, For some reason even though all the Android files were removed, I still had the android folder locally, and the following error:

This app is using a deprecated version of the Android embedding. To avoid unexpected runtime failures, or future build failures, try to migrate this app to the V2 embedding. Take a look at the docs for migrating an app: https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects The plugin firebase_auth requires your app to be migrated to the Android embedding v2. Follow the steps on the migration doc above and re-run this command.

was thrown only if there is a presence of an android folder. Shouldn't be a problem if there's no presence of an android folder