Collabo93 / SortGroup

https://www.curseforge.com/wow/addons/sortgroup
MIT License
9 stars 5 forks source link

Lua error on 9.2 #1

Closed edumserrano closed 1 year ago

edumserrano commented 2 years ago

Since 9.2 came out the addon is causing errors when friendly nameplates are enabled and I'm in a dungeon on a raid. I've also tried to update to the latest beta version but the issue is still present.

The errors that I see are:

[ADDON_ACTION_BLOCKED] AddOn 'SortGroup' tried to call the protected function 'CompactRaidFrame17:Show()'.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function `Show'
[string "@FrameXML\CompactUnitFrame.lua"]:378: in function `CompactUnitFrame_UpdateVisible'
[string "@FrameXML\CompactUnitFrame.lua"]:309: in function <FrameXML\CompactUnitFrame.lua:307>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `CompactUnitFrame_UpdateAll'
[string "@FrameXML\CompactUnitFrame.lua"]:48: in function <FrameXML\CompactUnitFrame.lua:45

and

FrameXML\CompactUnitFrame.lua:1122: Attempt to access forbidden object from code tainted by an AddOn
[string "=[C]"]: in function `Hide'
[string "@FrameXML\CompactUnitFrame.lua"]:1122: in function `CompactUnitFrame_UpdateClassificationIndicator'
[string "@FrameXML\CompactUnitFrame.lua"]:1380: in function <FrameXML\CompactUnitFrame.lua:1374>
[string "=[C]"]: ?
[string "=[C]"]: in function `CompactUnitFrame_UpdateAuras'
[string "@FrameXML\CompactUnitFrame.lua"]:96: in function <FrameXML\CompactUnitFrame.lua:45>

Locals:
(*temporary) = <unnamed> {
 0 = <userdata>
}

As you can see on the second error it doesn't say it's from SortGroup but I believe it is since when I disabled it the error seems to have gone away (or perhaps I need to do more testing).

Is there any more information I can provide to help resolve this?

With gratitude, Eduardo Serrano

edumserrano commented 2 years ago

Please disregard the second error about Attempt to access forbidden object from code tainted by an AddOn. That seems to be caused by another addon. See https://github.com/jordonwow/bigdebuffs/issues/367

Collabo93 commented 2 years ago

Sorry for the late response~ I didn't enter a single dungeon since 9.2, so didn't notice. Will look into it.

edumserrano commented 2 years ago

Actually the problem might be with this addon @Collabo93.

I've been adding info on CompactUnitFrame.lua error issue on the BigDebuffs repo but after seeing this issue 'Use LibUIDropDownMenu to avoid taint' on the Auctionator repo, I've used the command /console taintLog 1 and the output from the logs doesn't mention BigDebuffs it only mentions SortGroup.

Taint error log:

4/23 13:06:22.083  Execution tainted by SortGroup while reading CompactRaidFrameContainer_TryUpdate - Interface\AddOns\Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua:62 CompactRaidFrameContainer_OnEvent()
4/23 13:06:22.083      CompactRaidFrameContainer:OnEvent()
4/23 13:06:22.083  An action was blocked in combat because of taint from SortGroup - CompactRaidFrame2:Show()
4/23 13:06:22.083      Interface\FrameXML\CompactUnitFrame.lua:378 CompactUnitFrame_UpdateVisible()
4/23 13:06:22.083      Interface\FrameXML\CompactUnitFrame.lua:309
4/23 13:06:22.083      CompactUnitFrame_UpdateAll()
4/23 13:06:22.083      Interface\FrameXML\CompactUnitFrame.lua:116
4/23 13:06:43.330  An action was blocked in combat because of taint from SortGroup - CompactRaidFrame2:Show()
4/23 13:06:43.330      Interface\FrameXML\CompactUnitFrame.lua:378 CompactUnitFrame_UpdateVisible()
4/23 13:06:43.330      Interface\FrameXML\CompactUnitFrame.lua:309
4/23 13:06:43.330      CompactUnitFrame_UpdateAll()
4/23 13:06:43.330      Interface\FrameXML\CompactUnitFrame.lua:116
4/23 13:07:05.827  An action was blocked in combat because of taint from SortGroup - CompactRaidFrame2:Show()
4/23 13:07:05.827      Interface\FrameXML\CompactUnitFrame.lua:378 CompactUnitFrame_UpdateVisible()
4/23 13:07:05.827      Interface\FrameXML\CompactUnitFrame.lua:309
4/23 13:07:05.827      CompactUnitFrame_UpdateAll()
4/23 13:07:05.827      Interface\FrameXML\CompactUnitFrame.lua:116
... <It goes on forever repeating the same error>

Auctionator fixed it with this PR Use LibUIDropDownMenu to avoid CUF taint.

The issue happens for me in raids and dungeons when friendly nameplates are enabled. Haven't tested other content. I'm using version 5.0.3 beta.

edumserrano commented 2 years ago

@Collabo93 any luck looking into this? Any more info I can provide that might help troubleshoot this ?

Collabo93 commented 1 year ago

Old WoW Version - closed