search

CollaboraOnline / collabora-mattermost

Mattermost plugin to integrate Collabora Online so that users can view or edit files directly in the chat.
Mozilla Public License 2.0
49 stars 20 forks source link

BUG - Unencoded WOPISrc #82

Open timar opened 1 day ago

timar commented 1 day ago

I see frequently in coolwsd logs lines like this:

Nov 14 14:21:19 cp-share-cool coolwsd[420]: wsd-00420-01243 2024-11-14 14:21:19.739425 +0000 [ websrv_poll ] WRN  WOPISrc validation error: unencoded WOPISrc [https://chat.collabora.com/plugins/com.collaboraonline.mattermost/api/v1/wopi/files/bjrym5t8afrm5rp85ngtcpkosy] in URL: /browser/0123623/cool.html?WOPISrc=https://chat.collabora.com/plugins/com.collaboraonline.mattermost/api/v1/wopi/files/bjrym5t8afrm5rp85ngtcpkosy| wsd/RequestDetails.cpp:37
eszkadev commented 1 day ago

So this seems to be bug in Mattermost integration - which requests cool.html with unencoded WOPISrc param. cc: @hfiguiere @meven

https://sdk.collaboraonline.com/docs/How_to_integrate.html#website-that-presents-the-editing-capabilities

<id> should be URL-safe base64 (base64url) encoded, ie. only contain letters (A-Z, a-z), numerals (0-9), and - and _ symbols.