Open cosminh11 opened 2 hours ago
I tried to fix this in the frontend by mapping those different request and response values. I have a patch that mostly works.
I would open a pull-request (should I?) but there's a problem: sometimes when you open the navigator, the sidebar button gets selected too. That's because we also get a "statechanged" event for it as well (steps to reproduce, below).
So I'm not sure: do we want to do this in the frontend (and try to find a solution for this "both-are-selected" issue)? Or should we use different commands, maybe try to send the commands we're receiving (i.e. send .uno:Sidebar
instead of .uno:SidebarDeck.PropertyDeck
).
I would need some advice.
Steps to reproduce the remaining "both-are-selected" issue:
statechanged: .uno:Sidebar=true
statechanged: { "locale": "en-US", "commandName": ".uno:SidebarDeck.NavigatorDeck", "state": "true" }
statechanged: { "locale": "en-US", "commandName": ".uno:SidebarDeck.NavigatorDeck", "state": "false" }
statechanged: { "locale": "en-US", "commandName": ".uno:Sidebar", "state": "true" }
statechanged: { "locale": "en-US", "commandName": ".uno:Sidebar", "state": "false" }
statechanged: { "locale": "en-US", "commandName": ".uno:SidebarDeck.NavigatorDeck", "state": "true" }
statechanged: { "commandName": ".uno:SidebarDeck.NavigatorDeck", "state": "false" }
statechanged: .uno:Sidebar=false
statechanged: .uno:Sidebar=true
statechanged: { "locale": "en-US", "commandName": ".uno:SidebarDeck.NavigatorDeck", "state": "true" }
Describe the Bug
When you activate or deactivate the sidebar or the navigator, either from the menu or from the notebook bar, neither do the menu entries get checked or unchecked, nor do the buttons get selected or deselected.
Other features, such as "formatting marks" do show the current state, so for consistency I would expect the sidebar and the navigator to do the same.
Steps to Reproduce
With the compact view
With the tabbed view
Expected Behavior
The 'Sidebar' and 'Navigator' menu entries and notebook bar buttons appear as checked and selected, respectively, depending on whether their corresponding feature is shown or hidden.
Actual Behavior
The 'Sidebar' and 'Navigator' menu entries and notebook bar buttons never appear as checked / selected.
Screenshots
Desktop
Additional Context
The status of these buttons and menu entries seems to be determined by the UNO commands that are sent and received.
The difference between these two and 'Formatting Marks' (which works as expected) is that in the case of 'Formatting Marks' the command name is the same both for the request and the response ('.uno:ControlCodes'), while for Sidebar and Navigator they are different:
uno .uno:ControlCodes
statechanged: .uno:ControlCodes=true
uno .uno:SidebarDeck.PropertyDeck
statechanged: { "locale": "en-US", "commandName": ".uno:Sidebar", "state": "true" }
uno .uno:Navigator
statechanged: { "locale": "en-US", "commandName": ".uno:SidebarDeck.NavigatorDeck", "state": "true" }