search

CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.85k stars 701 forks source link

Rename wopi request doesnt contain lock header #1307

Open xklonx opened 3 years ago

xklonx commented 3 years ago

Describe the bug https://wopi.readthedocs.io/projects/wopirest/en/latest/files/RenameFile.html clearly states that rename request must contain current lock on file otherwise wopi host must response 409, but collabora doesnt send such header

To Reproduce Open file put new name press enter

Expected behavior Wopi host gets request with X-WOPI-Lock header

Actual behavior Request doesnt contain X-WOPI-Lock header

Desktop (please complete the following information)

xklonx commented 3 years ago

In addition to this, it is clear from the documentation that the response should have one property - Name, but it seems that colabora needs the Url property , because without it, it returns the old name back, even getting a 200 response. Besides, colabora seems to be sending the contents of a file with a rename request, which, in my opinion, contradicts the documentation.

Ashod commented 2 years ago

Thanks for reporting this @xklonx. Unfortunately, locks are still not fully supported by most implementations. There are outstanding tasks to improve locking, but this depends a lot on the support that the host implementations provide.