CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.82k stars 697 forks source link

Notebookbar selected item layout #2126

Closed Andreas-Kainz closed 3 years ago

Andreas-Kainz commented 3 years ago

If there is an command selected at the notebookbar, the icon background is gray and the label is black

2021-04-24 00_41_44-ws-cdb0e9e9-e710-4615-863b-cac4f19fb659_0 - noVNC Automatic Spell Check is selected and Word Count not

I suggested to a better layout for selected items

Andreas-Kainz commented 3 years ago

In classic mode the icon has a frame, which look similar to the dropdown for font name.

2021-04-24 00_44_58-ws-cdb0e9e9-e710-4615-863b-cac4f19fb659_0 - noVNC

Andreas-Kainz commented 3 years ago

The Notebookbar selection brand on the default nextcloud client

2021-04-24 00_46_50-Welcome to Nextcloud Hub docx - Dateien - Nextcloud

Andreas-Kainz commented 3 years ago

I prefer how it look in LibreOffice, an blue frame with an transparent area fill setting. Maybe cool can use the app color for selection so blue in writer, green in calc, ...

2021-04-24 00_47_56-Untitled 1 - LibreOfficeDev Writer

Andreas-Kainz commented 3 years ago

additional space like in #1212 would be cool

Andreas-Kainz commented 3 years ago

Which color or variable should be used for select command?

App dependent color

writer 2021-04-26 10_12_21-ws-1922949a-db85-4014-a53b-8917a344ad5b_0 - noVNC calc 2021-04-26 10_13_41-ws-1922949a-db85-4014-a53b-8917a344ad5b_0 - noVNC impress 2021-04-26 10_10_47-ws-1922949a-db85-4014-a53b-8917a344ad5b_0 - noVNC

use the highlight-color

2021-04-26 11_02_29-ws-1922949a-db85-4014-a53b-8917a344ad5b_0 - noVNC

Andreas-Kainz commented 3 years ago

code for notebookbar.css

.hasnotebookbar .ui-content.unotoolbutton.selected:not(.has-label):not(.inline) {
    border-radius: 2px;
    border: 1px solid rgb(30, 139, 205);
    background-color: rgb(30, 139, 205, 0.2);
}
Andreas-Kainz commented 3 years ago

What I like is, that the layout is similar to what our LibreOffice Windows users already know.

pedropintosilva commented 3 years ago

I think it's a nice idea : ) I just wonder how this can clash with current theming we are allowing integrators to have via the css vars (that currently affects that accent colour). we currently listened to the primary color from let's say NC and use it exactly in that place.

and I also wonder if changing that accent colour used here for communicating select status could go wrong (example when on impress things that are on will be somehow more near to red is might not be that good but maybe I'm being overly cautious)

and is it using the same colour from the TAB? (it should be using the css var) and how would it look on the switcher buttons?:

image

Andreas-Kainz commented 3 years ago

Select and switcher buttons should use the same color/layout. Hover the same. Like it's on LibreOffice desktop.

The question is, shoul the color be app specific or use the primary color let's say NC.