search

CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.84k stars 701 forks source link

loolwsd not self restarted after upgrade #3125

Closed antiuser closed 9 months ago

antiuser commented 3 years ago

Hi there! Maybe this is a bug, need to research

After every loolwsd upgrade via apt i need start service again (no restart after upgrade loolwsd) To Reproduce Steps to reproduce the behavior:

  1. apt update
  2. apt upgrade
  3. systemctl status loolwsd and this inactive (died)
  4. then i should run systemctl start loolwsd
  5. service started normally
  6. im using loolwsd from official mirror 
    
apt-cache policy loolwsd
loolwsd:
Installed: 6.4.10-10
Candidate: 6.4.10-10
Version table:
*** 6.4.10-10 500
    500 https://www.collaboraoffice.com/repos/CollaboraOnline/CODE-debian9 ./ Packages
    100 /var/lib/dpkg/status

**Expected behavior**
I assume that after upgrading package loolwsd this service should be restarted automatically
**Actual behavior**
Service not self restarted after upgrade

**Desktop (please complete the following information)**
 - OS: Debian 9.13 x64
thebearon commented 3 years ago

Do you have the service enabled? What does systemctl status loolwsd say? If it is enabled, it does restart automatically.

antiuser commented 3 years ago

Service is enabled because after system restart service automatically started. This situation happens persistent when i upgrade loolwsd. Sorry, i forget apply LC_ALL=en_US due upgrade So

# apt upgrade
..
Подготовка к распаковке …/17-loolwsd_6.4.11-3_amd64.deb …
Распаковывается loolwsd (6.4.11-3) на замену (6.4.10-10) …
..
Настраивается пакет loolwsd (6.4.11-3) …
..

After i see that service was stopped (assume while apt upgrade)

# systemctl status loolwsd.service 
● loolwsd.service - Collabora Online WebSocket Daemon
   Loaded: loaded (/lib/systemd/system/loolwsd.service; enabled; vendor preset: enabled)
   Active: inactive (dead) since Wed 2021-09-22 18:09:40 +05; 38s ago
 Main PID: 24600 (code=exited, status=0/SUCCESS)

сен 22 16:10:24 nextcloud.local loolwsd[24600]: wsd-24600-26170 2021-09-22 11:10:24.094378 [ docbroker_1f2 ] ERR  Doc [/tmp/convert-to/tmp24600dqaaaa/callbackwrapper:] is taking too long to load. Will kill proce
сен 22 16:10:24 nextcloud.local loolwsd[24600]: wsd-24600-26193 2021-09-22 11:10:24.110352 [ docbroker_1f3 ] ERR  Doc [/tmp/convert-to/tmp24600eqaaaa/callbackwrapper:] is taking too long to load. Will kill proce
сен 22 16:26:28 nextcloud.local loolwsd[24600]: wsd-24600-30717 2021-09-22 11:26:28.259693 [ docbroker_1f4 ] WRN  Waking up dead poll thread [HttpSynReqPoll], started: false, finished: false| ./net/Socket.hpp:68
сен 22 16:26:28 nextcloud.local loolwsd[24600]: wsd-24600-30717 2021-09-22 11:26:28.358456 [ docbroker_1f4 ] WRN  Waking up dead poll thread [HttpSynReqPoll], started: false, finished: false| ./net/Socket.hpp:68
сен 22 16:26:34 nextcloud.local loolwsd[24600]: wsd-24600-30717 2021-09-22 11:26:34.634687 [ docbroker_1f4 ] WRN  Ignoring attempted read from 20| ./net/Socket.hpp:1021
сен 22 18:09:40 nextcloud.local systemd[1]: Stopping Collabora Online WebSocket Daemon...
сен 22 18:09:40 nextcloud.local loolwsd[24600]: kit-30718-24627 2021-09-22 13:09:40.433901 [ kit_spare_1f5 ] SIG   Shutdown signal received: SIGINT
сен 22 18:09:40 nextcloud.local loolwsd[24600]: wsd-24600-24600 2021-09-22 13:09:40.451313 [ loolwsd ] SIG   Shutdown signal received: SIGINT
сен 22 18:09:40 nextcloud.local loolwsd[24600]: wsd-24600-24600 2021-09-22 13:09:40.452294 [ loolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/LOOLWSD.cpp:2231
сен 22 18:09:40 nextcloud.local systemd[1]: Stopped Collabora Online WebSocket Daemon.

and after that i started service manually

# systemctl start loolwsd.service
# systemctl status loolwsd.service 
● loolwsd.service - Collabora Online WebSocket Daemon
   Loaded: loaded (/lib/systemd/system/loolwsd.service; enabled; vendor preset: enabled)
   Active: active (running) since Wed 2021-09-22 18:10:38 +05; 2s ago
 Main PID: 24094 (loolwsd)
    Tasks: 7 (limit: 4915)
   CGroup: /system.slice/loolwsd.service
           ├─24094 /usr/bin/loolwsd --version --o:sys_template_path=/opt/lool/systemplate --o:child_root_path=/opt/lool/child-roots --o:file_server_root_path=/usr/share/loolwsd
           ├─24117 /usr/bin/loolforkit --losubpath=lo --systemplate=/opt/lool/systemplate --lotemplate=/opt/collaboraoffice6.4 --childroot=/opt/lool/child-roots/ --clientport=9980 --masterport=loolwsd-RhgscfYk -
           └─24128 /usr/bin/loolforkit --losubpath=lo --systemplate=/opt/lool/systemplate --lotemplate=/opt/collaboraoffice6.4 --childroot=/opt/lool/child-roots/ --clientport=9980 --masterport=loolwsd-RhgscfYk -

сен 22 18:10:41 nextcloud.local loolwsd[24094]: wsd-24094-24116 2021-09-22 13:10:41.197495 [ prisoner_poll ] DBG  Removing socket #20 (of 3) from prisoner_poll| net/Socket.cpp:432
сен 22 18:10:41 nextcloud.local loolwsd[24094]: wsd-24094-24116 2021-09-22 13:10:41.197517 [ prisoner_poll ] DBG  #20 Thread affinity set to 0 (was 0x7fef56a1c700).| ./net/Socket.hpp:308
сен 22 18:10:41 nextcloud.local loolwsd[24094]: wsd-24094-24116 2021-09-22 13:10:41.197556 [ prisoner_poll ] TRC  Calling addNewChild in disposition's move thing to add to NewChildren| wsd/LOOLWSD.cpp:2359
сен 22 18:10:41 nextcloud.local loolwsd[24094]: wsd-24094-24116 2021-09-22 13:10:41.197589 [ prisoner_poll ] TRC  Adding one child to NewChildren| wsd/LOOLWSD.cpp:516
сен 22 18:10:41 nextcloud.local loolwsd[24094]: wsd-24094-24116 2021-09-22 13:10:41.197608 [ prisoner_poll ] INF  Have 1 spare child after adding [24128].| wsd/LOOLWSD.cpp:520
сен 22 18:10:41 nextcloud.local loolwsd[24094]: wsd-24094-24116 2021-09-22 13:10:41.197625 [ prisoner_poll ] TRC  Notifying NewChildrenCV| wsd/LOOLWSD.cpp:523
сен 22 18:10:41 nextcloud.local loolwsd[24094]: wsd-24094-24116 2021-09-22 13:10:41.197676 [ prisoner_poll ] TRC  ppoll start, timeoutMicroS: 5000000 size 2| net/Socket.cpp:327
сен 22 18:10:41 nextcloud.local loolwsd[24094]: wsd-24094-24094 2021-09-22 13:10:41.197694 [ loolwsd ] TRC  Have 1 new children.| wsd/LOOLWSD.cpp:4187
сен 22 18:10:41 nextcloud.local loolwsd[24094]: wsd-24094-24094 2021-09-22 13:10:41.197743 [ loolwsd ] INF  WSD initialization complete: setting log-level to [warning] as configured.| wsd/LOOLWSD.cpp:4194
сен 22 18:10:41 nextcloud.local loolwsd[24094]: Ready to accept connections on port 9980.
Ezinnem commented 2 years ago

@antiuser, please can you test again using an updated coolwsd version and see if the issue still occurs at your end?

antiuser commented 2 years ago

@Ezinnem Hi! After upgrading to coolwsd (22.05.4.1-1) from (22.05.3.1-1) coolwsd doesnt restart automatically

● coolwsd.service - Collabora Online WebSocket Daemon
   Loaded: loaded (/lib/systemd/system/coolwsd.service; enabled; vendor preset: enabled)
   Active: inactive (dead) since Wed 2022-08-03 15:15:34 +05; 53s ago
 Main PID: 869 (code=exited, status=0/SUCCESS)

авг 03 15:15:33 nextcloud.local coolwsd[869]: wsd-00869-00869 2022-08-03 15:15:33.651301 +0500 [ coolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:3095
авг 03 15:15:33 nextcloud.local coolwsd[869]: wsd-00869-00869 2022-08-03 15:15:33.651337 +0500 [ coolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:3095
авг 03 15:15:33 nextcloud.local coolwsd[869]: wsd-00869-00869 2022-08-03 15:15:33.651356 +0500 [ coolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:3095
авг 03 15:15:33 nextcloud.local coolwsd[869]: wsd-00869-00869 2022-08-03 15:15:33.651387 +0500 [ coolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:3095
авг 03 15:15:33 nextcloud.local coolwsd[869]: wsd-00869-00869 2022-08-03 15:15:33.651406 +0500 [ coolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:3095
авг 03 15:15:33 nextcloud.local coolwsd[869]: wsd-00869-00869 2022-08-03 15:15:33.651434 +0500 [ coolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:3095
авг 03 15:15:33 nextcloud.local coolwsd[869]: wsd-00869-00869 2022-08-03 15:15:33.651453 +0500 [ coolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:3095
авг 03 15:15:33 nextcloud.local coolwsd[869]: wsd-00869-00869 2022-08-03 15:15:33.651481 +0500 [ coolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:3095
авг 03 15:15:33 nextcloud.local coolwsd[869]: wsd-00869-00869 2022-08-03 15:15:33.651499 +0500 [ coolwsd ] WRN  Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:3095
авг 03 15:15:34 nextcloud.local systemd[1]: Stopped Collabora Online WebSocket Daemon.
unnilennium commented 1 year ago

confirmed on same issue with rpm packaging got same issue on 2 upgrades: Jun 29 04:20:51 Mis à jour : coolwsd.x86_64 23.05.1.2-1 Jul 12 04:03:02 Mis à jour : coolwsd.x86_64 23.05.1.3-1

I use auto yum update. on each situation symptoms were service not available on the morning looking at logs service has been stopped at the moment of the upgrade and never restarted while the spec scriptlet is supposed to do so. see https://bugs.koozali.org/show_bug.cgi?id=12372