search

CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.76k stars 676 forks source link

F5 while in presentation mode reloads the page #4530

Open thebearon opened 2 years ago

thebearon commented 2 years ago

4519 disabled the browser reload in the UI, and launches the presentation in Impress, just like desktop LibreOffice.

However, while in the presentation, F5 still initiates browser reload. The key should be disabled in the presentation engine as well, probably somewhere in the below source file:

https://opengrok.libreoffice.org/xref/core/filter/source/svg/presentation_engine.js?r=e889c9b8

timar commented 2 years ago

Why would someone press F5 in presentation mode?

timur-g commented 1 year ago

Once in presentation mode, I don't see why someone would press F5 (as F5 is browser reserved key for refresh). But still it would be better to have that key disabled, although the probability and so importance is very low/trivial. Not sure how importance is marked here. Maybe by converting to Enhancement (to avoid accidental press). What I wrote in #4519 for starting with F5 seems more important.

thebearon commented 1 year ago

The idea was that in online we should disable browser reload on F5 in general, because it disrupts the app. The merger PR achieved that in a normal view (at least that was the plan, I'll review the recent comment there). but not in presentation view. I just think browser F5 behavior in general should be disabled, but I'm fine to consider it an enhancement.