CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.86k stars 704 forks source link

Persist avatar for editors in comments #4590

Open juliusknorr opened 2 years ago

juliusknorr commented 2 years ago

Describe the bug When a user leaves a comment by default the avatar sent over as UserExtraInfo will be displayed next to any comment added to the document by the user. However after the user leaves the editing, the avatar information is lost.

Additional context

As per discussion with @kendy it would be required to have a way to persist the avatar image in the document. From the Nextcloud perspective it would be enough to persist the URL to the avatar, however for potential usage in offline Collabora Office it would make more sense to keep a copy of the actual image.

Open questions:

Would fix https://github.com/nextcloud/richdocuments/issues/2049

Leaving this up to @kendy for further evaluation of the technical details on the core/cool side.

Darshan-upadhyay1110 commented 1 year ago

hello @juliushaertl can you explain bit more on this issue as i am not getting the idea what to look here ?

juliusknorr commented 1 year ago

Any specific question? Maybe to summarize the problem itself in slightly different words:

An avatar can be passed to Collabora as a remote URL which is what we do with Nextcloud through UserExtraInfo. However when the user leaves the document, the avatar URL is not available anymore in Collabora as the user was removed from the list of views.

Steps to reproduce: