CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.87k stars 710 forks source link

Calc: Formula bar gets cleared when focused in protected cells. #5301

Open gohrner opened 2 years ago

gohrner commented 2 years ago

Describe the bug If a Calc cell is protected, the formula bar get cleared if focused, instead of showing the cell's content as read-only text.

To Reproduce

  1. Open the attached test.ods in CODE
  2. Click on Cell E7
  3. Click at the formular bar.

Expected behavior Formula bar shows "Test" in readonly style.

Actual behavior Formula bar becomes empty on click.

Ezinnem commented 2 years ago

Thanks for reporting.

I can reproduce the issue on COOLWSD 22.05 version

hoffmannlin commented 1 year ago

this is a serious security problem,

which version can be repaire or is the previous version normal?

gohrner commented 1 year ago

this is a serious security problem,

It's only the display in the formula bar which does not match the cell's contents. No data is damaged.

So I don't think it's a security or data safety issue, however it's still somewhat annoying for sure. :)

hoffmannlin commented 1 year ago

image

sorry, i have difference problem,

i can not saw tool > protecte sheet

then i can not protecte some cell to disable modify

so i means is a security problem my version is 22.05.10.1

timur-g commented 1 year ago

This is minor issue with no damage, I'd rather call it enhancement to give infomration like in Core: "Protected cells cannot be modified". As explained, not a security problem. Protect is enhancment issue #551.

timur-g commented 1 year ago

After fixes in https://github.com/CollaboraOnline/online/pull/6768 click to Formula bar gives "Protected cells cannot be modified" which is good and the main issue here. Formula bar still remains empty whcih is not grave, but it should not be,

cornouws commented 6 months ago

Screenshot from 2024-05-13 14-41-37

hfiguiere commented 6 months ago

Things have have changed since the issue was filed: we can now protect/unprotect the sheet, which enable the cell protection. Note that is the file was already like that, it didn't change.

The cell protection tab was removed sometime and added back with sheet protection.

Now selecting a protected cell and then trying to edit in the formula bar delete the content of the formula bar. It doesn't delete the data though. This is also not the behaviour in LibreOffice which should help us pinpoint where the problem it.