CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.86k stars 707 forks source link

Calc search not working in read mode #5366

Open sergioatzori opened 2 years ago

sergioatzori commented 2 years ago

Describe the bug Calc search doesn't jump to line if edit is not enabled

To Reproduce Steps to reproduce the behavior:

  1. Go to a xls/csv document (read mode)
  2. Use hamburger menu to trigger search on mobile
  3. Try to search
  4. Nothing happens (if the item is not in current view)
  5. Activate edit mode
  6. try to search: obtain result

Expected behavior Search should scroll to item even in view document mode

Actual behavior User cannot search on a Calc document if he doesn't enable edit mode

Desktop (please complete the following information)

Smartphone (please complete the following information)

Screenshots

Ezinnem commented 2 years ago

serch-in-readonly

I do not encounter this issue on my end.

Please can you share the COOLWSD version that you are using @sergioatzori ?

sergioatzori commented 2 years ago

I do not encounter this issue on my end.

Please can you share the COOLWSD version that you are using @sergioatzori ?

Yes of course: coolwsd 22.05.7 but the example you show doesn't matter about my issue: the point is that the search item must not be in the current viewport (the viewport must scroll to highlight the element found at search trigger): this behavior happens when in read mode.

pedropintosilva commented 2 years ago

I tested, confirmed.

Searching for a text outside of the current view is not possible. This bug only happens in spreadsheet documents (when in readonly mode) --> search return no results (which is not true)