CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.88k stars 710 forks source link

Track Changes: XML broken: The end tag w:ins does not match with the start tag w:rPr #5594

Closed Commifreak closed 1 year ago

Commifreak commented 1 year ago

Describe the bug Sometimes, if track changes is enabled, collabora breaks the xml block for a change, resulting in xml error and broken document. One can fix it to remove the not starting w:ins tag and repait the document but it happens again after a few edits

To Reproduce No valid steps known :(

Expected behavior No XML corruption

Actual behavior This is one w:pRr block:

            <w:pPr>
                <w:pStyle w:val="Normal"/>
                <w:bidi w:val="0"/>
                <w:spacing w:lineRule="auto" w:line="252"/>
                <w:ind w:left="0" w:right="0" w:hanging="0"/>
                <w:jc w:val="both"/>
                <w:rPr>
                    <w:del w:id="392" w:author="Username" w:date="2022-12-14T09:27:26Z"/>
                </w:ins>
            </w:rPr>
        </w:pPr>

You see, the </w:ins> has no starting tag which breaks the document. The document is then not editable anymore.

Screenshots none

Desktop (please complete the following information)

Smartphone (please complete the following information) none

Additional context CODE: 22.05.8.4.1 via docker

I dont know if there is another issue already - did not found anything.

thebearon commented 1 year ago

Please try to find an exact reproducer, we can't do anything about the problem until there is one.

thebearon commented 1 year ago

Probably the same issue as this: tdf#147892

Commifreak commented 1 year ago

Indeed. Seem to be it

thebearon commented 1 year ago

Let's assume it is. The fix is now ported to co-22.05 as the following commit, and will be part of the next CODE release. https://github.com/LibreOffice/core/commit/f91e083e2565f07a6ebd2f2c0aa69bbacb4cfd19