Cypress test stability: Avoid closing the sidebar before every test

[pedropintosilva]

Describe the bug Currently we always close the sidebar via the UI even on tests where we are not testing the sidebar at all. This is costly and not necessary for those tests.

Example running: make -C cypress_test run-desktop spec=writer/scrolling_spec.js forces cypress to first detect the scroll indicator then click; find the sidebar button and then click it. All that and we are still not sure when (exactly) the sidebar is not visible anymore.

Better would be to make sure that the sidebar is closed without UI (either by shortcut or by sending the uno:SidebarShow). Still this is not ideal..

Ideally we would switch off the sidebar via the ui_defaults https://sdk.collaboraonline.com/docs/theming.html?highlight=sidebar#user-interface-modifications

But I don't think SpreadsheetSidebar=false or TextSidebar=false actually work anymore (now that the sidebar is JS)

[Rash419]

Flaky tests in CI:

• Desktop:
• [ ] impress/undo_redo_spec.js

Redo:
      Timed out retrying after 6000ms
      + expected - actual

      -'Hello Wor'
      +'Hello Worl'

• [x] calc/sheet_operation_spec.js

Switching sheet sets the view that contains cell-cursor:
 CypressError: Timed out retrying after 6050ms: `cy.click()` failed because this element is detached from the DOM.
`<button class="spreadsheet-tab spreadsheet-tab-selected" id="spreadsheet-tab1" draggable="true">Sheet2</button>`
Cypress requires elements be attached in the DOM to interact with them.

• [x] impress/annotation_spec.js

  Comment Scrolling: omit slides without comments:
  CypressError: Timed out retrying after 6050ms: `cy.click()` failed because this element:
  `<a class="leaflet-control-scroll-up" href="#" title="Scroll up annotations">▲</a>`
  is being covered by another element:
  `<div class="jsdialog jsdialog-overlay cancellable" style="z-index: 10;"></div>`

• [ ] writer/scrolling_spec.js

Scroll through document: Scrolling to left/right:
      Timed out retrying after 6000ms
      + expected - actual

      -'242'
      +'0'

• [ ] image_operation_spec.js

  Resize image when keep ratio option enabled and disabled:
  AssertionError: expected 63 to be close to 93 +/- 10

Tests on which CI gets stuck:

• Mobile:
• [ ] writer/searchbar_spec.js

Makefile:683: recipe for target '/home/collabora/jenkins/workspace/tinderbox_online_master_debug_vs_co-22.05/cypress_test/workdir/track/mobile/writer/searchbar_spec.js.done' failed

[pedropintosilva]

Maybe we could start using app actions ? https://www.cypress.io/blog/2019/01/03/stop-using-page-objects-and-start-using-app-actions/#application-actions

[pedropintosilva]

https://github.com/cypress-io/cypress-realworld-app