search

CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.79k stars 681 forks source link

23.05 : Smart Picker does nothing on Compact view in NC25 (works from NC26) #6489

Closed Ezinnem closed 1 year ago

Ezinnem commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce

  1. Open a .odg file
  2. In Compcat View; go to Insert > Smark Picker

Notice that clicking on it does nothing

In Tabbed View, the menu item seems to be missing Screenshot from 2023-05-31 10-23-30

GulsahKose commented 1 year ago

I can confirm that Smart Picker does nothing but couldn't find what should it do. Couldn't find corresponding core feature or core menu item to understand. Can you help me to understand?

when i trace the code it triggers following lines browser/src/control/Toolbar.js-879- case 'remotelink': browser/src/control/Toolbar.js:880: this.fire('postMessage', { msgId: 'UI_PickLink' }); but couldn't find any listeners for that message.

eszkadev commented 1 year ago

UI_PickLink is a postmessage sent to the integrator (Nextcloud). So it should be handled in richdocuments (Nextcloud plugin for Collabora Online: https://github.com/nextcloud/richdocuments)

pedropintosilva commented 1 year ago

I think that menu entry should be there when testing it locally. Meaning, it should only be visible if integrator has that funcitonality

pedropintosilva commented 1 year ago

So to clarify we should probably check if WOPI within map has that feature as we do with other things (search for wopi'].Enable )

It seems we are already doing that for tabbed view, see this._map['wopi'].EnableRemoteLinkPicker