search

CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.83k stars 698 forks source link

calc comments don't have to be a red rectangle #7130

Open caolanm opened 1 year ago

caolanm commented 1 year ago

Is your feature request related to a problem?

The red rectangles in the spreadsheet that indicate a comment aren't very pretty and don't scale when the spreadsheet is zoomed in

Describe the solution you'd like

In https://github.com/CollaboraOnline/online/commit/ccb20f1ed329e483f52831858f711b3a0e73502d we moved the rendering of these into the browser, matching how they were doing in core. So just a simple fillRect in red. It might be nicer to at least draw something like a triangle that scales with the zoom.

caolanm commented 1 year ago

@pedropintosilva maybe of interest to you

pedropintosilva commented 1 year ago

@caolanm : that's great news , thanks for the ping!

pedropintosilva commented 1 year ago

Color

I think it would be good to steer away from red color and instead use yellow or blue. Probably best to go with yellow so to make it stand out (and avoid too similar colors nearby).

Shape

I would go with something that can signify "open comment, pop out" but still using a basic shape (no icon)