CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.76k stars 676 forks source link

TABLES STYLES: Inserting or removing a row/column changes entire table's formatting #7280

Open mmeeks opened 11 months ago

mmeeks commented 11 months ago

This is to track the following upstream bug, related to feedback from Philippe Hemmel.

Comment 5, reproducer

I found the reason: Table has table style "Default Style". If you add a row, the table changes back to setings of default style. I created a new table without a style in comment 2 and so I couldn't reproduce it. Steps to reproduce:

  1. Create an empty table
  2. Choose table style "Default Style"
  3. Mark all and change alignment to center and font size to 10
  4. Put cursor in one cell and add a row or a column

Actual result: All cells change alignment and font size (Undo doesn't change this)

Expected result: Only the new row or column has style of "Default Style".

You recieve the expected result, if you mark the whole row or column. https://bugs.documentfoundation.org/show_bug.cgi?id=126008

Above is the actual bug, however there've been changes that might've made it more common in online, see: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ef46afe71751929b8b17d278d83c8e3ceefc862f and https://cgit.freedesktop.org/libreoffice/core/commit/?id=8620b204b51a9e0552a0002f7f06292bdfad37a7 ...which were to fix the issue that when inserting tables in online Writer via the Insert Table dialog, the default was to omit borders, and because of the change for #3491, the table ended up being invisible on the screen.

fifh commented 11 months ago

Interesting ! I made some new tests based on what you describe @mmeeks

It depends on the table style used :

In this case, to reproduce :

  1. Create an table with some text
  2. Choose table style "Default table Style" or another style that doesn't contain a specific font (where the font has not been changed)
  3. Put cursor in one cell and add a row

Actual result : All cells change font to Calibri

Expected result : The new line is using the "Table content " paragraph style as the other cells

I attach an example. All the tables using Calibri are bad : Default table style , Academic, arawa. The tables with the arawa2 and Simple Grid Rows are ok. doc arawa table insert row test v2.odt

hfiguiere commented 11 months ago

I have a document that reproduce the problem everytime.