search

CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.85k stars 704 forks source link

calc perf: switching sheets spams font bits #7488

Closed mmeeks closed 1 year ago

mmeeks commented 1 year ago

When switching sheets in calc I get quite some jsdialog spam which seems to add little value for lots of text:

1697712893668 INCOMING: jsdialog: { "jsontype": "notebookbar", "action": "update", "id": 0, "control": { "id": "fontnamecombobox", "type": "combobox", "text": "Times New Roman", "enabled": true, "children": [ { "id": "", "type": "pushbutton", "text": "", "enabled": true, "text": "", "symbol": "SPIN_DOWN"}, { "id": "", "type": "edit", "text": "Times New Roman", "enabled": true}, { "id": "", "type": "borderwindow", "text": "", "enabled": true, "children": [ { "id": "", "type": "edit", "text": "", "enabled": true}]}], "entries": { "": { "": "Alef"}, "": { "": "Amiri"}, "": { "": "Amiri Quran"}, "": { "": "Caladea"}, "": { "": "Cantarell"}, "": { "": "Carlito"}, "": { "": "Century Schoolbook L"}, "": { "": "David Libre"}, "": { "": "DejaVu Math TeX Gyre"}, "": { "": "DejaVu Sans"}, "": { "": "DejaVu Sans Condensed"}, "": { "": "DejaVu Sans Light"}, "": { "": "DejaVu Sans Mono"}, "": { "": "DejaVu Serif"}, "": { "": "DejaVu Serif Condensed"}, "": { "": "Dingbats"}, "": { "": "EmojiOne Color"}, "": { "": "Frank Ruhl Hofshi"}, "": { "": "Gentium Basic"}, "": { "": "Gentium Book Basic"}, "": { "": "IPAGothic"}, "": { "": "Karla"}, "": { "": "Liberation Mono"}, "": { "": "Liberation Sans"}, "": { "": "Liberation Sans Narrow"}, "": { "": "Liberation Serif"}, "": { "": "Linux Biolinum G"}, "": { "": "Linux Libertine Display G"}, "": { "": "Linux Libertine G"}, "": { "": "Miriam Libre"}, "": { "": "Nimbus Mono L"}, "": { "": "Nimbus Roman No9 L"}, "": { "": "Nimbus Sans L"}, "": { "": "Noto Color Emoji"}, "": { "": "Noto Emoji"}, "": { "": "Noto Kufi Arabic"}, "": { "": "Noto Mono"}, "": { "": "Noto Naskh Arabic"}, "": { "": "Noto Naskh Arabic UI"}, "": { "": "Noto Nastaliq Urdu"}, "": { "": "Noto Sans"}, "": { "": "Noto Sans Arabic"}, "": { "": "Noto Sans Arabic UI"}, "": { "": "Noto Sans Armenian"}, "": { "": "Noto Sans Avestan"}, "": { "": "Noto Sans Balinese"}, "": { "": "Noto Sans Bamum"}, "": { "": "Noto Sans Batak"}, "": { "": "Noto Sans Bengali"}, "": { "": "Noto Sans Brahmi"}, "": { "": "Noto Sans Buginese"}, "": { "": "Noto Sans Buhid"}, "": { "": "Noto Sans Canadian Aboriginal"}, "": { "": "Noto Sans Carian"}, "": { "": "Noto Sans Cham"}, "": { "": "Noto Sans Cherokee"}, "": { "": "Noto Sans Cond"}, "": { "": "Noto Sans Coptic"}, "": { "": "Noto Sans Cuneiform"}, "": { "": "Noto Sans Cypriot"}, "": { "": "Noto Sans Deseret"}, "": { "": "Noto Sans Devanagari"}, "": { "": "Noto Sans Egyptian Hieroglyphs"}, "": { "": "Noto Sans Ethiopic"}, "": { "": "Noto Sans Georgian"}, "": { "": "Noto Sans Glagolitic"}, "": { "": "Noto Sans Gothic"}, "": { "": "Noto Sans Gujarati"}, "": { "": "Noto Sans Gurmukhi"}, "": { "": "Noto Sans Hanunoo"}, "": { "": "Noto Sans Hebrew"}, "": { "": "Noto Sans Imperial Aramaic"}, "": { "": "Noto Sans Inscriptional Pahlavi"}, "": { "": "Noto Sans Inscriptional Parthian"}, "": { "": "Noto Sans Javanese"}, "": { "": "Noto Sans JP Bold"}, "": { "": "Noto Sans JP Regular"}, "": { "": "Noto Sans Kaithi"}, "": { "": "Noto Sans Kannada"}, "": { "": "Noto Sans Kayah Li"}, "": { "": "Noto Sans Kharoshthi"}, "": { "": "Noto Sans Khmer"}, "": { "": "Noto Sans KR Bold"}, "": { "": "Noto Sans KR Regular"}, "": { "": "Noto Sans Lao"}, "": { "": "Noto Sans Lepcha"}, "": { "": "Noto Sans Light"}, "": { "": "Noto Sans Limbu"}, "": { "": "Noto Sans Linear B"}, "": { "": "Noto Sans Lisu"}, "": { "": "Noto Sans Lycian"}, "": { "": "Noto Sans Lydian"}, "": { "": "Noto Sans Malayalam"}, "": { "": "Noto Sans Mandaic"}, "": { "": "Noto Sans Meetei Mayek"}, "": { "": "Noto Sans Mongolian"}, "": { "": "Noto Sans Myanmar"}, "": { "": "Noto Sans New Tai Lue"}, "": { "": "Noto Sans NKo"}, "": { "": "Noto Sans Ogham"}, "": { "": "Noto Sans Ol Chiki"}, "": { "": "Noto Sans Old Italic"}, "": { "": "Noto Sans Old Persian"}, "": { "": "Noto Sans Old South Arabian"}, "": { "": "Noto Sans Old Turkic"}, "": { "": "Noto Sans Oriya"}, "": { "": "Noto Sans Osmanya"}, "": { "": "Noto Sans Phags Pa"}, "": { "": "Noto Sans Phoenician"}, "": { "": "Noto Sans Rejang"}, "": { "": "Noto Sans Runic"}, "": { "": "Noto Sans Samaritan"}, "": { "": "Noto Sans Saurashtra"}, "": { "": "Noto Sans SC Bold"}, "": { "": "Noto Sans SC Regular"}, "": { "": "Noto Sans Shavian"}, "": { "": "Noto Sans Sinhala"}, "": { "": "Noto Sans Sundanese"}, "": { "": "Noto Sans Syloti Nagri"}, "": { "": "Noto Sans Symbols"}, "": { "": "Noto Sans Syriac Eastern"}, "": { "": "Noto Sans Syriac Estrangela"}, "": { "": "Noto Sans Syriac Western"}, "": { "": "Noto Sans Tagalog"}, "": { "": "Noto Sans Tagbanwa"}, "": { "": "Noto Sans Tai Le"}, "": { "": "Noto Sans Tai Tham"}, "": { "": "Noto Sans Tai Viet"}, "": { "": "Noto Sans Tamil"}, "": { "": "Noto Sans TC Bold"}, "": { "": "Noto Sans TC Regular"}, "": { "": "Noto Sans Telugu"}, "": { "": "Noto Sans Thaana"}, "": { "": "Noto Sans Thai"}, "": { "": "Noto Sans Tibetan"}, "": { "": "Noto Sans Tifinagh"}, "": { "": "Noto Sans Ugaritic"}, "": { "": "Noto Sans Vai"}, "": { "": "Noto Sans Yi"}, "": { "": "Noto Serif"}, "": { "": "Noto Serif Armenian"},

@eszkadev any thoughts on that ? =) we shouldn't need to re-fill the entire font combobox even if the font changes in the new cell on the next tab right (?).

mmeeks commented 1 year ago

We also get this:

1697712893665 INCOMING: jsdialog: { "jsontype": "notebookbar", "action": "update", "id": 0, "control": { "id": "fontsizecombobox", "type": "combobox", "text": "12 pt", "enabled": true, "children": [ { "id": "", "type": "pushbutton", "text": "", "enabled": true, "text": "", "symbol": "SPIN_DOWN"}, { "id": "", "type": "edit", "text": "12 pt", "enabled": true}, { "id": "", "type": "borderwindow", "text": "", "enabled": true, "children": [ { "id": "", "type": "edit", "text": "", "enabled": true}]}], "entries": { "": { "": "6 pt"}, "": { "": "7 pt"}, "": { "": "8 pt"}, "": { "": "9 pt"}, "": { "": "10 pt"}, "": { "": "10.5 pt"}, "": { "": "11 pt"}, "": { "": "12 pt"}, "": { "": "13 pt"}, "": { "": "14 pt"}, "": { "": "15 pt"}, "": { "": "16 pt"}, "": { "": "18 pt"}, "": { "": "20 pt"}, "": { "": "21 pt"}, "": { "": "22 pt"}, "": { "": "24 pt"}, "": { "": "26 pt"}, "": { "": "28 pt"}, "": { "": "32 pt"}, "": { "": "36 pt"}, "": { "": "40 pt"}, "": { "": "42 pt"}, "": { "": "44 pt"}, "": { "": "48 pt"}, "": { "": "54 pt"}, "": { "": "60 pt"}, "": { "": "66 pt"}, "": { "": "72 pt"}, "": { "": "80 pt"}, "": { "": "88 pt"}, "": { "": "96 pt"}}, "selectedCount": 1, "selectedEntries": { "": { "": 7}}, "command": ".uno:FontHeight", "entries": [ "6 pt", "7 pt", "8 pt", "9 pt", "10 pt", "10.5 pt", "11 pt", "12 pt", "13 pt", "14 pt", "15 pt", "16 pt", "18 pt", "20 pt", "21 pt", "22 pt", "24 pt", "26 pt", "28 pt", "32 pt", "36 pt", "40 pt", "42 pt", "44 pt", "48 pt", "54 pt", "60 pt", "66 pt", "72 pt", "80 pt", "88 pt", "96 pt"], "selectedEntries": [ "7"], "selectedCount": 1}}

but that's much smaller.

mmeeks commented 1 year ago

COOLWSD version: 23.05.5.1 (git hash: 5927fe17 (E)) LOKit version: Collabora Office 23.05.5.1 (git hash: 6195ba3) Served by: openSUSE Leap 15.5 Server ID: 6dd3e9b2

I had the navigator open, but not the sidebar.