CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.83k stars 701 forks source link

Calc: many chart dialogue boxes' tabs have no effect #7629

Open Smegheid opened 11 months ago

Smegheid commented 11 months ago

Describe the Bug

In #7265 I reported a problem where calc's chart options for trendlines apparently weren't working properly. This was fixed in fairly short order, but it appears this is actually a symptom of a wider problem - a lot of the dialogue boxes for various chart options don't work in Collabora.

I'm going to refer to this example spreadsheet and compare it to what I see in libreoffice: test trendline.ods. This isn't anything particularly interesting - it was just something I cobbled together with a small set of randomish data with an underlying trend that I put together for the other ticket.

When attempting to manipulate various aspects of the chart in the spreadsheet, the expected dialogue box is displayed, but making changes and then clicking "OK" has no effect. In every case, re-opening the dialogue box shows the settings prior to any changes that were attempted.

Interestingly, tabs on some dialogue boxes work where neighbouring tabs in the same dialogue do not.

At this time, I see problems with the following dialogue boxes:

However, I cannot guarantee this list is exhaustive; someone more knowledgeable about Collabora needs to walk through all of the chart options and test every one of them, as there are a very large number that are currently not working.

Steps to Reproduce

To use the y-axis scale tab as an example:

  1. Open the example spreadsheet.
  2. Double-click the chart to edit the chart.
  3. Double-click the y-axis to bring up the Y-axis dialogue box.
  4. Click the Scale tab.
  5. Attempt to change the y-axis from linear to log scale: click the 'Logarithmic scale' checkbox, then press OK.
  6. Note that the y-axis is still plotted on the original linear scale.
  7. Bring up the dialogue again. Note that 'Logarithmic scale' is not checked, despite having been selected in the previous step.

Similar effects are seen in a bunch of other dialogue boxes' tabs. The behaviour is similar each time - changes made have no effect, and re-opening the dialogue box shows the settings changed were not remembered.

Expected Behavior

The changes made in a dialogue box tab should take effect and should be visible the next time the dialogue is opened. In the above example, the chart should end up plotted with a logarithmic y scale, and opening the dialogue box again should show the 'Logarithmic scale' checkbox is checked.

Actual Behavior

As indicated, the selected options have no effect on the chart, and the options modified are not reflected in the dialogue box once opened again.

Screenshots

Videos illustrate the problem much more concisely than screenshots. Additionally, a direct comparison against Libreoffice to show expected behaviour in the same circumstances would probably help illustrate the difference:

Desktop

This was tested on a Linux desktop:

Smartphone

Not tested.

Server

To reduce the chance that this is simply something wrong with my test install of Nextcloud AIO, I signed up for use of Collabora's own trial server. and reproduced the issue there. Help -> About shows:

COOLWSD version: 23.05.5.3snapshot (git hash: 3e8fe64) LOKit version: Collabora Office 23.05.5.20231106 (git hash: ca5225a) Served by: Ubuntu 18.04.6 LTS Server ID: 35c5f242

Additional Context

I probably can't stress strongly enough that the list of examples probably isn't complete. Someone that knows the product really needs to walk through all of the possible dialogue boxes and test all of their tabs.

Smegheid commented 7 months ago

In case it's relevant, this is still an issue with the current Nextcloud AIO, which reports a newer version than last tested:

COOLWSD version: 23.05.9.2 (git hash: 9831402 (E)) LOKit version: Collabora Office 23.05.9.2 (git hash: 3f7a66d) Served by: Debian GNU/Linux 12 (bookworm) Server ID: 1e062452

Smegheid commented 3 weeks ago

Still an issue in the next major version:

COOLWSD version: 24.04.7.2(git hash: d5ebff5 (E)) LOKit version: Collabora Office 24.04.7.2(git hash: 8c74383) Served by: Debian GNU/Linux 12 (bookworm) Server ID: c634d7eb

thefeli73 commented 1 day ago

Same issue here. I'm running Collabora using the Nextcloud AIO installer

COOLWSD version: 24.04.8.1(git hash: 8475197 (E))
LOKit version: Collabora Office 24.04.8.1(git hash: 5c1b808)
Served by: Debian GNU/Linux 12 (bookworm)

i cant add a data series to the secondary y-axis, so its impossible to see correlations with differently data of different orders of magnitude. I can add the secondary y-axis, but if i add a series to the secondary y-axis nothing happens and the option is reset next time i open the modal