CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.69k stars 654 forks source link

UI Bugs with Visio files (vsdx) #7808

Open vherrlein opened 6 months ago

vherrlein commented 6 months ago

Describe the Bug

  1. The loader hangs with Connectecting state at 0% till the document opens. image
  2. As expected, the visio file is opened in read only mode, however the navigation menu with a desktop web browser is not working with the following JS errors in the console. image

Steps to Reproduce

From a desktop web browser (Microsoft Edge or Google Chrome):

  1. Open a Visio document with the extension VSDX
  2. Wait till the document opens with the hanging loading page
  3. When the document is rendered, open the web browser console

Expected Behavior

The modern menu bar should render properly with available commands in read-only mode.

Actual Behavior

The menu bar is not working and using the ugly look & feel. image

Screenshots

Cf. above.

Desktop

Smartphone

Not applicable, works fine with iOS 17.1 and the following web browser:

Additional Context

After looking at the UI source code, the issue seems coming from the notbookbar control which is removed if the web browser is not mobile: https://github.com/CollaboraOnline/online/blob/eeea0002423146b0633d42806af0fc9839fd64fc/browser/src/control/Control.UIManager.js#L949

Regarding to the loading page "hanging", the websocket is not sending statusindicators like the other documents: image

vherrlein commented 6 months ago

With Collabora Online version 23.05.6.3

image

Andreas-Kainz commented 6 months ago

visio files aren't supportet by LibreOffice.

vherrlein commented 6 months ago

visio files aren't supportet by LibreOffice.

Sorry, but LibreOffice supports Microsoft Visio files, at least in read only mode in order to convert those to ODG files.

Cf, the library used by LibreOffice: https://wiki.documentfoundation.org/DLP/Libraries/libvisio