CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.85k stars 702 forks source link

Multi-user text editing status bar confusion for the current page in Writer #8270

Closed vmiklos closed 8 months ago

vmiklos commented 8 months ago

Describe the Bug

Multi-user editing can result in the cursor of user 1 to influence the status bar of user 2, with this document:

orig.odt

Steps to Reproduce

  1. Open the bugdoc.
  2. User 1 goes to page 3.
  3. User 2 goes to page 19.
  4. User 2 deletes the "page 19" text on page 19.

Expected Behavior

Status bar of user 2 says we're on page 19.

Actual Behavior

image

I.e. status bar for user 2 says we're on page 3, which is the cursor position of user 1.

Additional Context

Tested with Chrome and Linux, but probably the problem is general.

Tex2002ans commented 8 months ago

I spotted this last week too during COOL Weekly Meeting 155. This was my exact version:

COOLWSD version: 23.05.8.4snapshot (git hash: fee6198(E)) LOKit version: Collabora Office 23.05.8.20240207 (git hash: 3797310) Served by: Ubuntu 22.04.3 LTS 4f7c80eb

and these were my notes. I had slightly different steps, but exact same symptoms:


Page Numbers in "Status Bar" Strangely flipping when "View > Sidebar" Goes ON/OFF

In Writer:

  1. Open ODT with many pages.
  2. View > Status Bar ON
  3. Click in page 1.
    • See Status bar shows "Page 1 of 9".
  4. View > Sidebar ON.
  5. Repeat Step 3 OFF/ON again multiple times.

In Steps 3/4, you'll see bug:

(I don't know if this had to do with different people editing at once, so the selected page was jumping to where users were...)

vmiklos commented 8 months ago

https://cgit.freedesktop.org/libreoffice/core/commit/?h=distro/collabora/co-23.05&id=fb33ed13f4f83f92de7d5276271ab0f95458e90b fixes this.