CollaboraOnline / online

Collabora Online is a collaborative online office suite based on LibreOffice technology. This is also the source for the Collabora Office apps for iOS and Android.
https://collaboraonline.com
Other
1.69k stars 654 forks source link

Collabora - Nextcloud, reporting missing .svg files as error. #8948

Open DaanSelen opened 2 months ago

DaanSelen commented 2 months ago

Describe the Bug

The Collabora Docker container has the wrong filepath in the error message and has missing .svg files.

Steps to Reproduce

  1. deploy collabora behind an NGINX Proxy Manager (with this extra configuration) with the described configuration from Collabora using this :

    # static files
    location ^~ /browser {
    proxy_pass https://192.168.2.2:9980;
    proxy_set_header Host $http_host;
    }
    
    # WOPI discovery URL
    location ^~ /hosting/discovery {
    proxy_pass https://192.168.2.2:9980;
    proxy_set_header Host $http_host;
    }
    
    # Capabilities
    location ^~ /hosting/capabilities {
    proxy_pass https://192.168.2.2:9980;
    proxy_set_header Host $http_host;
    }
    
    # main websocket
    location ~ ^/cool/(.*)/ws$ {
    proxy_pass https://192.168.2.2:9980;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "Upgrade";
    proxy_set_header Host $http_host;
    proxy_read_timeout 36000s;
    }
    
    # download, presentation and image upload
    location ~ ^/(c|l)ool {
    proxy_pass https://192.168.2.2:9980;
    proxy_set_header Host $http_host;
    }
    
    # Admin Console websocket
    location ^~ /cool/adminws {
    proxy_pass https://192.168.2.2:9980;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "Upgrade";
    proxy_set_header Host $http_host;
    proxy_read_timeout 36000s;
    }

Docker Compose

services:
  collabora:
    image: collabora/code:latest
    privileged: true
    container_name: 'collabora'
    networks:
      - cloud-nextcloud
    volumes:
      - /opt/colla/coolwsd.xml:/etc/coolwsd/coolwsd.xml
    ports:
      - 9980:9980/tcp
    restart: always
    environment:
      - username=admin
      - password=<PASSWORD>
      - domian=devnext\.domain\.com
      - server_name=devcolla\.domain\.com
      - extra_params=--o=ssl.enable=true
    cap_add:
      - MKNOD

networks:
  cloud-nextcloud:
    external: true
  1. Configure Nextcloud to use the Collabora Online instance, and it succesfully discovers it and connects.
  2. Whenever I want to open a document in Nextcloud -- it works, but the following error is generated:
    /usr/bin/coolmount: forced unmount of [/opt/cool/child-roots/1-71c9df07/BxxoXsjIIAU2Mci6/lo] failed: Invalid argument.
    /usr/bin/coolmount: forced unmount of [/opt/cool/child-roots/1-71c9df07/BxxoXsjIIAU2Mci6] failed: Invalid argument.
    frk-00030-00030 2024-05-01 14:27:46.337426 +0000 [ forkit ] WRN  The systemplate directory [/opt/cool/systemplate] is read-only, and at least [/opt/cool/systemplate//etc/hosts] is out-of-date. Will have to copy sysTemplate to jails. To restore optimal performance, make sure the files in [/opt/cool/systemplate/etc] are up-to-date.| common/JailUtil.cpp:425
    wsd-00001-00066 2024-05-01 14:27:46.492100 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request: [/browser/f12ee1f/images/dark/lc_searchnext.svg].| wsd/FileServer.cpp:751
    wsd-00001-00066 2024-05-01 14:27:46.492432 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request: [/browser/f12ee1f/images/dark/lc_searchprev.svg].| wsd/FileServer.cpp:751
    wsd-00001-00066 2024-05-01 14:27:46.499607 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request: [/browser/f12ee1f/images/dark/lc_statetablecellmenu.svg].| wsd/FileServer.cpp:751
    wsd-00001-00066 2024-05-01 14:27:46.501647 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request: [/browser/f12ee1f/images/dark/lc_zoom.svg].| wsd/FileServer.cpp:751
    wsd-00001-00066 2024-05-01 14:27:46.502485 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request: [/browser/f12ee1f/images/dark/lc_prev.svg].| wsd/FileServer.cpp:751
    wsd-00001-00066 2024-05-01 14:27:46.503214 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request: [/browser/f12ee1f/images/dark/lc_next.svg].| wsd/FileServer.cpp:751
    wsd-00001-00066 2024-05-01 14:27:46.547254 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request: [/browser/f12ee1f/images/lc_statetablecellmenu.svg].| wsd/FileServer.cpp:751
    wsd-00001-00066 2024-05-01 14:27:46.547858 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request: [/browser/f12ee1f/images/lc_zoom.svg].| wsd/FileServer.cpp:751

    I also have a rewrite to:

    <file_server_root_path desc="Path to the directory that should be considered root for the file server. This should be the directory containing cool." type="path" relative="true" default="browser/../">browser/dist/</file_server_root_path>

Expected Behavior

I expect the output the be correct in its path and to not give an error when it seems to work.

Actual Behavior

it gives an error and vaguely describes a problem

Screenshots

Maybe later if needed

Desktop

(Please complete the following information)

DaanSelen commented 2 months ago

I have looked into the mentioned images, but they never appeared in 22., 23. or 24. So why are they even referenced, most of the files are for dark mode.

But dark mode itself seems to work fine...

pedropintosilva commented 1 month ago

Thank you @DaanSelen for not only taking the time to test but for the comprehensive report. I'm looking at this now.

DaanSelen commented 4 weeks ago

From what I see - This issue is almost resolved with only this line remaining regarding the missing .svgs

[ websrv_poll ] ERR FileServerRequestHandler: File not found: Invalid URI request: [/browser/91c166d/images/dark/symbol_SPIN_DOWN.svg].| wsd/FileServer.cpp:676

Opening a new issue for the coolmnt issues.