CollaboraOnline / richdocumentscode

Built-in CODE Server app
https://apps.nextcloud.com/apps/richdocumentscode
Apache License 2.0
111 stars 26 forks source link

Typo in proxy.php #229

Closed RealKoenisch closed 1 year ago

RealKoenisch commented 1 year ago

Typo in line 85 proxy.php

{ $remoteFontConfig = "--o:remote_font_config.url=https://" . $_SERVER['HTTP_HOST'] . preg_replace("/richdocumentscode.*$/", "richdocuments/settings/fonts.json", _SERVER['REQUEST_URI']); }

correct { $remoteFontConfig = "--o:remote_font_config.url=https://" . $_SERVER['HTTP_HOST'] . preg_replace("/richdocumentscode.*$/", "richdocuments/settings/fonts.json", $_SERVER['REQUEST_URI']); }

the $ is missing at the 2nd $_SERVER

Pilzinsel64 commented 1 year ago

This might fix #226 🤔 EDIT: Tested on my end, but still didn't work.

Scarat95 commented 1 year ago

This might fix #226 🤔

Yep. Same issue as #226 After this fix it works again!

JazMTaz commented 1 year ago

Great catch, updated proxy.php line 85 and it is now fixed here as well, thanks.

timar commented 1 year ago

@RealKoenisch thanks!