search

CollaboratingPlatypus / PetaPoco

Official PetaPoco, A tiny ORM-ish thing for your POCO's
Other
2.07k stars 600 forks source link

Non parameterized queries can cause high memory usage #185

Open Shazwazza opened 10 years ago

Shazwazza commented 10 years ago

I've put all the details in a PR for NPoco here:

https://github.com/schotime/NPoco/pull/134

But decided it might be best to log an issue on this original project for completeness.

pleb commented 8 years ago

I would love this as a PR for PetaPoco. Would you have time?

We're looking for people #204.

Shazwazza commented 8 years ago

My original PR was pulled in and fixed in NPoco (as above link) and then enhanced so would need to look at how it's done there. Also note, this is the original blog post I wrote about this: http://shazwazza.com/post/petapoco-can-cause-high-memory-usage-with-certain-queries/

Have you already approached NPoco about collaboration? The project has moved way further ahead and it would be ideal to not have more than 2 different products based on the same core. They've also implemented all of the code to run on .Net CoreCLR.

pleb commented 8 years ago

I've reached out a few times with limited response. Given that I don't simply want to take the NPoco code without permission, the only choice is to forge ahead. CoreCLR is planned. However, I want to finish the integration tests and clean up before I implement it.