CollaboratingPlatypus / PetaPoco

Official PetaPoco, A tiny ORM-ish thing for your POCO's
Other
2.07k stars 600 forks source link

bugfix: OpenSharedConnectionAsync fails to invoke OnConnectionOpening #686

Closed Ste1io closed 1 year ago

Ste1io commented 1 year ago

Added tests for event invocation when opening shared connection with both synchronous and asynchronous methods. BaseDatabaseTests.OpenSharedConnectionAsync_WhenCalled_ShouldInvokeOnConnectionOpening() fails on this initial commit. The commit following this fixes Database.OpenSharedConnectionAsync(CancellationToken) to call OnConnectionOpening as the synchronous counterpart does, and results in a passing test.

I'll add tests for the remaining events shortly for completeness' sake.

closes #685