search

Collaborne / cordova-gallery-api

API to play with media gallery.
MIT License
3 stars 13 forks source link

Create proper package.json #1

Closed ankon closed 5 years ago

ankon commented 6 years ago

Since Cordova 7 the CLI uses cordova-fetch, which requires a package.json to exist.

This should be created using plugman createpackagejson $PWD, but due to https://github.com/apache/cordova-lib/pull/597 this doesn't work right now.

ankon commented 6 years ago

This is actually becoming critical: cordova 8 will seemingly remove the legacy parts that fetch using (a horribly outdated) npm, so we need to resolve this quickly: https://issues.apache.org/jira/browse/CB-9626

orgotech-robin commented 5 years ago

Im trying to install like the new instructions you added in the readme: cordova plugin add https://github.com/Collaborne/cordova-gallery-api.git --save --nofetch

But without success. Error:


Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Error: npm: Command failed with exit code 1 Error output:
npm ERR! premature close

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/XXX/.npm/_logs/2018-12-18T14_45_10_899Z-debug.log```
ankon commented 5 years ago

@ronnyroeller can you also update the README instructions now?

If I have to guess: We now require Cordova 8 and the use of npm for fetching, i.e. --no-fetch needs to go?

As to @orgotech-robin's comment: That is likely exactly what this issue was about, so it should be fixed now if I understand c17e227 correctly.