CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.37k stars 63 forks source link

[Feature Request] Unlock Genshin Impact fps limit #104

Closed abbaccadd0 closed 1 year ago

abbaccadd0 commented 1 year ago

The HI3 settings can be customized in Collapse Launcher, but GI can only customize the launch parameters. Maybe more options can be added to GI, such as resolution, window mode (full screen, windowed, borderless), unlocking the frame rate limit, or launching another program (like unlockfps) to launch GI. Collapse Launcher is beautiful and convenient, I like it a lot, these are just suggestions, not bugs. 🥰🥰🥰

bagusnl commented 1 year ago

Thank you for your interest in Collapse Launcher also for the suggestion! Settings menu for Genshin Impact (much like what's current Honkai Impact settings page looks like) is a planned feature we want to implement. But, for the FPS Unlock, we unfortunately might not be able to do that since it requires writing directly into GI process memory (different to what HI3 method of just modifying the game settings registry file). This in turns means that it would be a direct violation to Genshin's Terms of Service Point 2b Number IV and VIII.

With that in mind. Unfortunately, we cannot implement such feature in hope that miHoYo/Cognosphere will not take this project down (similar to what I explained here).

We are sorry that we can't implement such feature, though we hope that this won't stop you from supporting this project. ❤️

Cryotechnic commented 1 year ago

Per our contribution policy, which you can view here, we do not plan to implement this feature. Thank you for the suggestion!