CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games

MIT License

1.39k stars 64 forks source link

Double taskbar icon after a update #142

Open kleqing opened 1 year ago

kleqing commented 1 year ago

For those people always love pin a application. There is a problem with the application after the update. The app icon will be duplicate after a update.

Before update	After update

How to fix?

Temporary way
- Unpin and pin the application for each update.
Another way (I did not test yet)

I found many things in the Internet and I found a ways to fix it.
First of all is create a batch file which will remove the old taskbar icon and add a new one but seem like it is impossible because there are no shortcut after a update. So CSHarpLib which can create a temporary shortcut and then move it to %AppData%\Microsoft\Internet Explorer\Quick Launch\User Pinned\TaskBar is a way to fix it.

If the update are using InnoSetup to update the application for each new version, I think I can do something to help this project.

bagusnl commented 1 year ago

Try to make sure the shortcut you made to Collapse is to the executable on the root of the installation folder for Collapse, not the one inside the app-x.x.x folder. What I usually do is to pin them to start menu first then from the icon on start menu, pin them to task bar. Seems to work fine for me so far after the Squirrell implementation.

kleqing commented 1 year ago

The Collapse shortcut always execute from the root directory. I also pin it to taskbar from star menu. Even the target is on Collapse Launcher folder. But the problem still exist!

bagusnl commented 1 year ago

It's quite weird, this is how my shortcut looks like: My current env:

Windows 11 Insider Beta
Collapse Preview 1.70.4

kleqing commented 1 year ago

Same with you too

Windows 10 build 19041
Collapse Preview 1.70.04

But idk what happend to me. But last month I also have a same issues too on Windows 11

bagusnl commented 1 year ago

Double Taskbar icon after update

Cryotechnic commented 10 months ago

Potential cause may have been identified. We currently believe that this is because the application is not signed, which causes the app signature to change on every publish.

Self-signing, and potentially getting an OV (Organization Verified) certification in the long term may remediate the issue by having the application signature remain fixed and distributed through a trust certificate bundled with Collapse during its initial installation.

We'll keep this issue open and update it as we implement this into the launcher. This is currently planned for the 1.72+ release lifecycle.

Currently, the only way to remediate this issue is to unpin & re-pin the launcher. We apologize for any inconvenience we may have caused.

bagusnl commented 1 month ago

Ref

https://github.com/ppy/osu/pull/28743