CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.41k stars 65 forks source link

Build version indicator #220

Closed Cryotechnic closed 1 year ago

Cryotechnic commented 1 year ago

Adds a visual build version indicator by replacing the "PRE" with the version number.

Currently, we'd need a way to distinguish between stable and preview. Right now I've appended a "*" for preview builds, but maybe we should look into adding an icon or appending "-PRE" for preview?

Open to discussion.

Cryotechnic commented 1 year ago

All looks good to me, just adding some of my suggestion in comments,

Though I wonder if we need to also add a debug build identifier too but it seems like its unnecessary because we don't ship debug builds in our CI builds

Debug state will never get reached in a client environment because the application is already pre-compiled. So, really, we'd be helping developers. I think it's a cool change to add, but wondering if maybe we'd want to see the "next dev version" or something along those lines (e.g. display 1.71.5 in the case of preview, since it has not been released yet).

Cryotechnic commented 1 year ago

All looks good to me, just adding some of my suggestion in comments, Though I wonder if we need to also add a debug build identifier too but it seems like its unnecessary because we don't ship debug builds in our CI builds

Debug state will never get reached in a client environment because the application is already pre-compiled. So, really, we'd be helping developers. I think it's a cool change to add, but wondering if maybe we'd want to see the "next dev version" or something along those lines (e.g. display 1.71.5 in the case of preview, since it has not been released yet).

When compiling, Collapse is able to detect if the app is running in DEBUG, so I just changed the VersionIndicator to match that:

image image

Alternative: image image

bagusnl commented 1 year ago

Version number indicator

Cryotechnic commented 1 year ago

Merging as corrections have been made.