CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.36k stars 64 forks source link

[Bug]: Download stuck on 9.54GB #235

Closed EnergoStalin closed 1 year ago

EnergoStalin commented 1 year ago

Affected Version

1.71.6-PRE

Bug Behavior

It stuck's around 9.54GB of first package and then not let continue doing seemingly nothing cause no progress shown or i can see any activity in task manager. When restart and try to continue after some time produces unhelpful "Session has been disposed during initialization!" error. log-2023-08-18-pre1.71.6-id1.log DxDiag.txt

Expected Behavior

Continue download

Steps to reproduce

  1. Start download
  2. Wait until 9.54GB

Related Issues

No response

Screenshot(s)

https://github.com/neon-nyan/Collapse/assets/49844515/72558ac5-09b7-44c9-a447-ec639e001ffc

Additional Information

It persist in stable build as well after moving into PRE nothing changed except download progress fixed #210.

Starting over again works fine. Until stucking on 9.54GB...

bagusnl commented 1 year ago

Hi, thank you for submitting bug reports regarding Collapse! While we investigate said issue, can you do a full disk check on the drive you are trying to install to? Steps to do:

  1. Close Collapse and other programs
  2. Run Command Prompt with Administrator privileges
  3. Enter this command chkdsk C: /scan /R /perf /forceofflinefix
  4. Wait until its done and restart
  5. Try again
EnergoStalin commented 1 year ago

Check + reboot Screenshot 2023-08-18 045943

Now it wont resume at all(earlier at least stats was shown). Cancelling with "[Erro] Session has been disposed during initialization!" image Start over works as expected stucking on 9.54GB. image

I wonder maybe it's broken file on server side? I don't want try with vpn tho. It really seems like not Collapse problem since it works perfect with resuming and all until 9.54GB and i cant imagine another reason for stucking on such specific size.

bagusnl commented 1 year ago

Kind of want to confirm, is there no network activity when the download is stuck? Asking this because we have a problem in the UI Frontend as too fast internet speed causing UI to freeze

EnergoStalin commented 1 year ago

Yes i have 11MB's speed average image

bagusnl commented 1 year ago

Will ask some others to check this issue out, but for now leave it downloading like that for a couple minutes or so. In hope that its just CDN connection issue to your area

Tip: In PRE release you can leave the current page while its downloading to other game region and such so you don't have to wait in that screen and play other games

EnergoStalin commented 1 year ago

Thanks for the tip actually yesterday deleted StarRail to play some genshin. It automatically cancel download after minute or so with "[Erro] Session has been disposed during initialization!" in resume scenario so it wont continue downloading even if i leave it. When download again it might work but i don't think it would because i didn't exactly measure but i leaved it for approximately 5 min and still no progress.

Ps: Project looks cool i like the UI stuff along with tools section. I wish to see brandwidth limiting but it can be achieved in other ways so it's not really worth implementing i think.

bagusnl commented 1 year ago

I've just thought of another idea, since some of your chunks seems to be failing to connect and download, can you try lowering your download thread to 4 or even 1? One of our dev tried downloading GI like you just yesterday and found no issue so we are kind of leaning to connection issue in your area.

Also thank you! We are looking into implementing a bandwidth limiting also but not currently as some stuff needs to be ironed out until next stable sync with preview

EnergoStalin commented 1 year ago

It was 2 threads all the time image

Will try download with aria2

EnergoStalin commented 1 year ago

Okay aria also failed to download looks like file broken image

But holy with some random proxy it works image

Provider has different servers for regions? It was New York proxy

bagusnl commented 1 year ago

HYV download CDN usually just Akamai CDN sitting on top of Alibaba OSS (S3 bucket), could be Akamai is having some problem in your area right now.

Closing this as identified not a Collapse issue, but feel free to chime in still or re-open the issue if for some reason the bug keeps happening.

Thank you for using Collapse!

EnergoStalin commented 1 year ago

Windows proxy hotfix

/**
 * @param {string} url 
 * @param {string} host 
 */
function FindProxyForURL(url, host) {
  if(url.includes("autopatchhk.yuanshen.com"))
    return "PROXY <any http/https proxy here in format host:port>"

  return "DIRECT"
}