search

CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.41k stars 65 forks source link

Add a keyboard shortcut that reloads the Home page #324

Closed gablm closed 1 year ago

gablm commented 1 year ago

Hello! Per @bagusnl request, I've added a shortcut that reloads the Home page. It works as if the launcher was changing to the same region. The default key is F5 and can't be changed. Please let me know if any improvement is needed!

bagusnl commented 1 year ago

Related to #322

shatyuka commented 1 year ago

Can you add the Ctrl+R shortcut? I'm more used to that.

gablm commented 1 year ago

Can you add the Ctrl+R shortcut? I'm more used to that.

Sure thing. Ctrl+R is going to be the shortcut that can be changed and F5 remains the same.

Additionally, I've changed the behaviour in other pages. It will now reload them instead of going back to the home page.

I just want to know your opinions about if reloading should add +1 of that page to the Back button history or not.

bagusnl commented 1 year ago

Generally, a refresh shouldn't add any back button history. So, I'd say it shouldn't. Tested the current branch against main and its all looking good though, lemme know if you think its ready for merging!

gablm commented 1 year ago

I agree that it shouldn't and already changed that.

It seems ready for merging unless any of you still wants to add/change anything!

bagusnl commented 1 year ago

All good! Merging by squash

Thank you for the contribution!

Cc @all-contributors Add @gablm for code and translation

(Please ignore my last attempt LOL)

allcontributors[bot] commented 1 year ago

@bagusnl

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

I've put up a pull request to add @gablm! :tada: