search

CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.36k stars 64 forks source link

[Bug]: Add Checks before installing game for other files found #411

Open Dark-talon opened 6 months ago

Dark-talon commented 6 months ago

Affected Version

1.73.4

Bug Behavior

Doing game repair for Honkai 3rd Impact is showing files for completely different games. This happened on both of my laptop and desktop.

Expected Behavior

It shouldnt be looking at anything outside of honkai 3rd impact assets!

Steps to reproduce

  1. Open Collapse
  2. Pick Honkai 3rd Impact - Region Global
  3. Click Game Repair Tab
  4. Run Quick Check

Related Issues

No response

Screenshot(s)

image

Additional Information

No response

Cactism commented 6 months ago

For me, trying to repair the game or update the cache outright crashes for me. :teri_rip: Using v1.73.4 Preview however.

https://github.com/CollapseLauncher/Collapse/assets/88598340/160556ab-399a-491d-b048-0288a5ed6524

log-2024-03-01-pre1.73.4-id1.log

bagusnl commented 6 months ago

For me, trying to repair the game or update the cache outright crashes for me. :teri_rip: Using v1.73.4 Preview however.

https://github.com/CollapseLauncher/Collapse/assets/88598340/160556ab-399a-491d-b048-0288a5ed6524

log-2024-03-01-pre1.73.4-id1.log

Crashing on small window is a known bug, will try to release a hotfix soon(tm)

neon-nyan commented 6 months ago

Doing game repair for Honkai 3rd Impact is showing files for completely different games. This happened on both of my laptop and desktop. It shouldnt be looking at anything outside of honkai 3rd impact assets!

Are you sure that you don't have any game files inside your game installation? The folder contained by the game itself SHOULDN'T be mixed with other games. Please make sure that you don't put your World of Warcraft besides the Honkai data (like, BH3_Data, BH3.exe, etc.)

neon-nyan commented 6 months ago

For me, trying to repair the game or update the cache outright crashes for me. :teri_rip: Using v1.73.4 Preview however.

Recording.2024-03-01.203556.mp4

log-2024-03-01-pre1.73.4-id1.log

Crashing on small window is a known bug, will try to release a hotfix soon(tm)

@bagusnl this issue isn't related with UI/UX issue. The first person who opened this issue was having the World of Warcraft installation inside the Honkai's folder.

Removing the assignment and unrelated tag

neon-nyan commented 6 months ago

Also @Cactism, Can you please open an new issue for the problem you are having with? Just need to track of it.

Dark-talon commented 6 months ago

Doing game repair for Honkai 3rd Impact is showing files for completely different games. This happened on both of my laptop and desktop. It shouldnt be looking at anything outside of honkai 3rd impact assets!

Are you sure that you don't have any game files inside your game installation? The folder contained by the game itself SHOULDN'T be mixed with other games. Please make sure that you don't put your World of Warcraft besides the Honkai data (like, BH3_Data, BH3.exe, etc.)

Ugh... when I reinstalled HI3 with Collapse, I picked D:\Games\ expecting it to create the games folder like every single other installer in existence, instead it installed directly into it, so yes it makes sense now why the quick check was freaking out. The installer behavior should be changed imo in order to avoid this confusion for future people.

neon-nyan commented 6 months ago

@Dark-talon,

Thank you for the confirmation. For now, the launcher would install the game based on what the location is specified and doesn't create a new folder for it due to the same behaviour from Official Launcher.

But sure, We will consider this as an improvement plan in the future.