search

CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.41k stars 65 forks source link

[Bug]: Star Rail repair does not regard multiple VO languages #448

Closed bagusnl closed 4 months ago

bagusnl commented 8 months ago

Affected Version

Collapse 1.73.8

Bug Behavior

Star Rail game repair does not check multiple VO language

Expected Behavior

All installed language should be checked

Steps to reproduce

  1. Install multiple language in Star Rail
  2. Remove or modify one of the pck from unused audio vo
  3. Check repair

Related Issues

No response

Screenshot(s)

No response

Additional Information

There is no pointer on where SR stores all installed VO languages but one way to see it is there is pck files (External.pck and VoBanks.pck, Note: HASH file might always be there just cause) inside StarRail_Data\Persistent\Audio\AudioPackage\Windows\[lang] folder as AudioLangRedord.txt (not a typo btw) only contains currently used language

VO lang pointer seems to be saved in StarRail_Data\Persistent\AudioLaucherRecord.txt (again, not a typo) saved as line separated text \r\n image

Cause

SR Repair only checks using the registry LanguageSettings_LocalAudioLanguage_h882585060 Ref: https://github.com/CollapseLauncher/Collapse/blob/893a80322ad736954f21824083044bf3d17584b6/Hi3Helper.Core/Classes/Preset/Classes/PresetConfigV2.cs#L212-L228 https://github.com/CollapseLauncher/Collapse/blob/893a80322ad736954f21824083044bf3d17584b6/CollapseLauncher/Classes/RepairManagement/StarRail/Fetch.cs#L337