CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.41k stars 65 forks source link

[Bug]: Preview version; Discord RPC is showing when idling, even when the option is disabled in App Settings #477

Closed BobbyWibowo closed 5 months ago

BobbyWibowo commented 5 months ago

Affected Version

1.80.8 Preview

Bug Behavior

N/A

Expected Behavior

N/A

Steps to reproduce

  1. Enable "Show Discord Presence"
  2. Disable "Show RPC when idling"

Related Issues

No response

Screenshot(s)

ShareX_CollapseLauncher_20240607-132533
ShareX_Vesktop_20240607-132553

Additional Information

Tried turning all the RPC-related options on/off, in case it's some kind of display mismatch with actual config values, but it didn't seem to be the case.

shatyuka commented 5 months ago

Get back to the home page?

BobbyWibowo commented 5 months ago

@shatyuka It remains

After further testing, it looks like going to App Settings kickstart the RPC instantly. When exiting App Settings, it doesn't update the RPC and just let it run with the same status of "Changing App Settings".

Additionally, starting the game, then exiting it, also won't stop RPC from still saying "In Game" with timer still running. This behavior in particular is observed even when re-launching Collapse fresh without going to App Settings.

shatyuka commented 5 months ago

Can not reproduce here, it seems to be a Discord latency. Do you have another device for observing Discord status?

BobbyWibowo commented 5 months ago

@shatyuka Ah, it looks like the behavior only occurs in Vencord/Vesktop

I remember reading something about it in 1.73.4 release notes. Looks like your PR was only merged after arrpc 3.4.0 was released, so another release with the fix doesn't exist yet, which I suppose also means custom clients won't have it just yet.

I thought I was certain Stable release of Collapse didn't have the issue with Vesktop (I just switched to Preview channel within a day before posting this issue), but I tried a Portable version of 1.73.8 earlier, and could confirm the issue was also there. Guess I just never paid attention.

tl;dr, it looks like custom clients just don't have the necessary fix to RPC added yet. Sorry for the false alarm!