CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.41k stars 65 forks source link

[Bug]: Tray icon does not appear in full install #478

Closed bluebudg-e closed 5 months ago

bluebudg-e commented 5 months ago

Affected Version

1.73.8 (full install)

Bug Behavior

Minimizing the program does not cause the tray icon to appear, so the program has to be closed through the task manager if it has to be used again. Compared to the portable version, it does not appear even when starting the program.

Expected Behavior

The tray icon in the portable version is always present in the system tray.

Steps to reproduce

Installing and running the 'full install' version of Collapse.

Related Issues

No response

Screenshot(s)

Additional Information

One note: the UAC popup for the 'full install' executable does not say that it is signed

bluebudg-e commented 5 months ago

new update yay uninstalled the old version but my dummy head uninstalled the full game all problems seem to be gone now (on the full install)

bagusnl commented 5 months ago

Update on this one, we will be migrated to MSI installer which SignPath would be able to sign both the MSI and the contents inside of it instead of the current implementation which only able to sign the installer itself.

The commit is on https://github.com/CollapseLauncher/Collapse/commit/b3a0c6feffa54cecefc1c0f5bc8fadf3551e60ca but currently reverted as we are still not ready with the other implementation such as the uninstall method that might break after an update