CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.41k stars 65 forks source link

[Bug]: Locale code error when updating Genshin Impact #503

Closed Devyatyi9 closed 5 months ago

Devyatyi9 commented 5 months ago

Affected Version

1.80.11

Bug Behavior

Error after press "Update game" button

The error ``` System.Collections.Generic.KeyNotFoundException: Locale code: Japanese is not supported! at CollapseLauncher.InstallManager.Base.InstallManagerBase`1.GetLanguageStringByLocaleCode(String localeCode) at CollapseLauncher.InstallManager.Base.InstallManagerBase`1.AddAdditionalVODiffAssetsToList(HttpClient httpClient, String requestedUrlFrom, String requestedUrlTo, List`1 sophonPreloadAssetList) at CollapseLauncher.InstallManager.Base.InstallManagerBase`1.StartPackageUpdateSophon(GameInstallStateEnum gameState, Boolean isPreloadMode) at CollapseLauncher.InstallManager.Base.InstallManagerBase`1.StartPackageDownload(Boolean skipDialog) at CollapseLauncher.Pages.HomePage.UpdateGameDialog(Object sender, RoutedEventArgs e) ```

Expected Behavior

should have started updating the game

Steps to reproduce

  1. Open launcher
  2. Press "Update game"

Related Issues

No response

Screenshot(s)

image

Additional Information

DxDiag.txt logs.zip

neon-nyan commented 5 months ago

Hi @Devyatyi9, Thank you for noticing. We just pushed a commit to fix this issue and ship it in the next hotfix update

Devyatyi9 commented 5 months ago

@neon-nyan I updated to the new version, but this error appeared, then the window closed and reopened.

Log ``` System.Exception: Couldn't acquire lock, is another instance running? at Squirrel.SingleGlobalInstance..ctor(String, TimeSpan) at Squirrel.UpdateManager.b__41_0() at System.Threading.Tasks.Task`1.InnerInvoke() at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object) --- End of stack trace from previous location --- at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object) at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&, Thread ) --- End of stack trace from previous location --- at Squirrel.UpdateManager.CheckForUpdate(Boolean , Action`1 , UpdaterIntention ) at CollapseLauncher.Updater.StartCheck() at CollapseLauncher.Pages.UpdatePage.GetSquirrelUpdate() at CollapseLauncher.Pages.UpdatePage._StartUpdateRoutine() at CollapseLauncher.Pages.UpdatePage.StartUpdateRoutine() ```
neon-nyan commented 5 months ago

Hi @Devyatyi9, That is expected. You can ignore the exception there and it should be fine. Just make sure that you are successfully updated your launcher to the latest version (1.80.12)