CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.36k stars 64 forks source link

[Bug]: Star Rail BiliBili - Dispatch Server Channel Incorrect #550

Closed studiobutter closed 2 weeks ago

studiobutter commented 1 month ago

Affected Version

1.80.17 (REL) - 1.81.0 (PRE) - 1.81.0d (DBG)

Bug Behavior

Repair Function isn't working correctly for HSR - BiliBili Server. Stable and Preview behavior: Repair Function somehow fall back to Star Rail - Global Repair Data on BiliBili Server. Cache Update Function Errors Debug: Repair and Cache Update Functions display error

VS Debug: Collapse Repair and Cache Update function for Star Rail - BiliBili was using the Dispatch URL with the wrong channel and sub_channel ids.

Expected Behavior

Repair and Cache Update Function should be using the correct metadata.

Debug: By using the correct channel and sub_channel ids

Steps to reproduce

Do a repair on Star Rail - BiliBili.

If on Debug, Console should give out all the dispatch correctly with the Dispatch URL using the correct URL and it's JSON prefixes

Related Issues

No response

Screenshot(s)

No response

Additional Information

Debug Log

neon-nyan commented 1 month ago

Update - 2024/08/03

The fix for this issue has been fixed alongside this change: https://github.com/CollapseLauncher/Collapse/compare/93cd7d382567...39b863d4d03e For the current stable/preview version, the fix has already been pushed via metadata update.

Can you confirm if the issue is fixed?

studiobutter commented 1 month ago

The repair function seems to be working correctly with the only issue being the necessary "unused" files for Cutscenes problem that all regions having. image

Otherwise, it's working as intended.

neon-nyan commented 1 month ago

Fixed the files incorrectly being detected as "Unused" https://github.com/CollapseLauncher/Collapse/compare/39b863d4d03ef965ab4e52c552782e90ff53d060...bb3807c2c3b562dc1ab806ad4e7a7d0d75484b74

The part of the code should've been removed as the behavior with the in-game update has been changed since v2.2

bagusnl commented 1 month ago

Note: Changes needed to fix this can't be (easily) back ported to stable. Either:

  1. Notify HSR: Bilibili user to move to preview
  2. Back port (by cherry picking) all necessary metadata changes to stable
Cryotechnic commented 2 weeks ago

Fixed in https://github.com/CollapseLauncher/CollapseLauncher-ReleaseRepo/commit/d69b8bb7e84da0dfb026a9a998ca394de15ccdb8