search

CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.36k stars 64 forks source link

[Request]: Per-app Discord RPC toggle? #562

Open BobbyWibowo opened 3 weeks ago

BobbyWibowo commented 3 weeks ago

Is your request related to a problem?

No

How is the feature request related to the problem?

No response

Describe your proposed solution

Heya there, was wondering if it's too much to ask for a per-app toggle for Discord RPC?

It's mainly motivated by the fact that Genshin devs showed interests in implementing their own Discord RPC, but it appears that they are using server-sided solution (via a Discord App) as opposed to hooking it into the game client itself.
Possibly because the game is multi-platform enough to warrant the convenience (i.e. when playing the game on my phone, despite not having Discord in it, activity would still show just fine on my PC).

I think going forward I'd prefer to use Genshin's own RPC, especially since it'll also display some in-game information. And they also seemingly have interests to implement even more things, according to the announcement post.

Nonetheless, other HoYo games have no signs of wanting to implement something like this just yet, so definitely would want to fallback on Collapse's.

Describe alternatives you've considered

N/A

Additional context

Announcement post: https://www.hoyolab.com/article/32305119

bagusnl commented 3 weeks ago

It's not too much to implement per-se, but we'll see how Discord prioritizes Genshin's RPC compared to Collapse's and we go from there.

If Discord always prioritizes Genshin's own instead of Collapse, I don't think this is needed. But if it's the other way around, we can bump this enhancement priority.

Thanks for the heads up!

BobbyWibowo commented 3 weeks ago

Just a quick heads-up that Discord may be prioritizing Genshin's own RPC when viewed by other people, probably because it's initiated a bit later down the line (i.e. Collapse's RPC starts when the game launches, Genshin's RPC starts about 10s after logging in and having entered the in-game world).

It's kinda whack, but basically my Discord desktop client will only show Collapse's RPC, when playing the game via Collapse on said PC. But on that same session, Discord mobile app will instead show Genshin's RPC after it initiates. I suspect that's what other people are seeing?