CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.37k stars 64 forks source link

[BUG] Failed to detect HI3 Settings #63

Closed muscularcandy67 closed 1 year ago

muscularcandy67 commented 1 year ago

image As you can see, the launcher thinks I have yet to launch the game once, but as you might already know, I did launch the game multiple times (I do play Honkai on a daily basis). The commit I am running is 7fd057f99048a6774da800e80bee20d23846d89a . This started since 6.2 update

neon-nyan commented 1 year ago

I haven't notice any key changes being made by miHoYo recently. Have you tried the Southeast Asia or other server as well?

muscularcandy67 commented 1 year ago

I tried on Mainland China and while of course I couldn't login due to not having a cn mhy account, the launcher detected the configuration. I have yet to try on other regions

neon-nyan commented 1 year ago

I see, got it! I will try to check it myself later.

Cryotechnic commented 1 year ago

This is the issue that I was talking to you about in my PR the other day. Can confirm that it is present on GLB as well.

neon-nyan commented 1 year ago

I think I get the culprit now. The InternalGameNameInConfig property in the metadata seems to be Incorrect. It supposed to be Honkai Impact 3rd instead of Honkai Impact 3rd glb. This is why the launcher cannot look up for the registry key and then set false at IsRegKeyExist causing the GameSettingsPage to get disabled.

image

I will be rolling out the new metadata shortly to fix this issue.

neon-nyan commented 1 year ago

This issue should've been fixed now by updating the metadata.

image
Cryotechnic commented 1 year ago

Can confirm it is fixed now. Thanks!

image

muscularcandy67 commented 1 year ago

Works! image