search

CollectionBuilder / collectionbuilder-contentdm

CollectionBuilder-CONTENTdm digital collection "Skin" generator (deprecated).
MIT License
9 stars 4 forks source link

problem with "Greater than" in cloud.js #34

Closed dcnb closed 4 years ago

dcnb commented 4 years ago

where_exp: 't','t[1] > termsMin'

Shouldn't this be greater or equal to?

I think the theme is confusing if it says minimum but then doesn't show up

evanwill commented 4 years ago

are you working from an out-of-date branch? i fixed that https://github.com/CollectionBuilder/collectionbuilder-contentdm/blob/master/_includes/js/cloud-js.html

last time you assigned it to me! :wink: a8052b58da8217f844aa61acfa1cab996b4771ce

dcnb commented 4 years ago

I followed the installation instructions on the website. So I must have had an outdated version.

Time for 1.03, I'd think.

On Tue, Feb 11, 2020 at 10:04 PM EvanWill notifications@github.com wrote:

are you working from an out-of-date branch? i fixed that

https://github.com/CollectionBuilder/collectionbuilder-contentdm/blob/master/_includes/js/cloud-js.html

last time you assigned it to me! 😉 a8052b5 https://github.com/CollectionBuilder/collectionbuilder-contentdm/commit/a8052b58da8217f844aa61acfa1cab996b4771ce

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CollectionBuilder/collectionbuilder-contentdm/issues/34?email_source=notifications&email_token=ACTM4GLIFWKP74IH4OF6J23RCOGORA5CNFSM4KTR7VU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELPRKCI#issuecomment-585045257, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTM4GM5PLRVEGSA465RIT3RCOGORANCNFSM4KTR7VUQ .

evanwill commented 4 years ago

The release still matches what is in the documentation--we need to be ready to update docs for a new release, since some of the config has changed. Probably wait until i rewrite the cloud layout