CollectionBuilder / collectionbuilder-csv

CollectionBuilder-CSV is a "stand alone" template for creating digital collection and exhibit websites using Jekyll and a metadata CSV.
MIT License
21 stars 16 forks source link

page_gen: #34

Closed sgraham3 closed 1 year ago

sgraham3 commented 1 year ago

I have tested both metadata_one and metadata_two and they both build on there own. When I uncomment and add the data names as the readme states, it builds with no errors and the site is empty. I have tried multiple combinations of commenting and adding with no luck. Does the metadata: need to be commented out?

[optional: only used if you need to tweak CB defaults or generate from more than one data file]:

page_gen:

evanwill commented 1 year ago

@sgraham3 can you share your repository to me? I am not exactly sure what you are trying to do, but here is some info that I think is the issue. The metadata and page_gen values do two separate things:

So I think in your case, you have metadata commented out, all the default pages will be empty, but there still will be pages built for your two CSVs--thus no errors.

Basically you can't use page_gen to concatenate multiple CSVs into one collection (by default)--generally you will want to combine those CSVs before putting into the collection. We set up page_gen config to allow you to generate other types of custom pages, which will require some customization to use. For example of how it can be used, HJCCC collection uses it--the main collection CSV set in metadata populates the Browse page etc (and generates each individual item page), a second CSV generates pages for each Glossary entry (e.g. a glossary term page).

sgraham3 commented 1 year ago

Thanks for fast and detailed response. I defiantly misunderstood what the page_gen was doing. I was trying to pull both csv files into one collection. Seemed like a good idea(easier to manage) to have separate csv for different types-formats.

evanwill commented 1 year ago

@sgraham3 yeah--I am thinking about that option now too and seeing if there is a way to cleanly build it into the template with out making anything too complicated! It would also be nice to for your type of use case to just set multiple in the metadata value (if you don't need to customize page_gen). The problem being we try to keep CB-GH options interchangeable with CB-CSV, and it would be hard to build into GH.

For now I tried to clarify a bit in the doc page the current limitations.

sgraham3 commented 1 year ago

@evanwill I think it would be a good idea but see how it may be overly complicated or not needed for most users needs. I am using cb it a little differently.

The updated docs defiantly clarify and explain much better, Thanks

evanwill commented 1 year ago

closing this, and opening a feature issue #35 to think about! Thanks @sgraham3